You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by yupbank <gi...@git.apache.org> on 2018/03/14 18:36:57 UTC
[GitHub] spark pull request #20825: add impurity stats in tree leaf node debug string
GitHub user yupbank opened a pull request:
https://github.com/apache/spark/pull/20825
add impurity stats in tree leaf node debug string
## What changes were proposed in this pull request?
right now the debug str of tree doesn't contains impurity stats, which is confusing, since we are not using the predictions directly, and some raw predictions of tree is redundant
## How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)
Please review http://spark.apache.org/contributing.html before opening a pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/yupbank/spark add-stats-in-debugstring
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/20825.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #20825
----
commit a6718f79aa1c93956e8cae38f32be13f857a99f5
Author: Peng Yu <pe...@...>
Date: 2018-03-14T18:34:28Z
add impurity stats in debug string
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20825: add impurity stats in tree leaf node debug string
Posted by davies <gi...@git.apache.org>.
Github user davies commented on the issue:
https://github.com/apache/spark/pull/20825
LGTM
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20825: add impurity stats in tree leaf node debug string
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20825
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20825: add impurity stats in tree leaf node debug string
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20825
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20825: add impurity stats in tree leaf node debug string
Posted by jkbradley <gi...@git.apache.org>.
Github user jkbradley commented on the issue:
https://github.com/apache/spark/pull/20825
I actually would prefer not to merge this change since it could blow up the size of the strings printed for some classification tasks with large numbers of labels. If people want to debug, they could trace through the tree manually.
Alternatively, I'd be OK with adding an optional argument which tells toDebugString to include the stats.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #20825: add impurity stats in tree leaf node debug string
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/20825
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20825: add impurity stats in tree leaf node debug string
Posted by davies <gi...@git.apache.org>.
Github user davies commented on the issue:
https://github.com/apache/spark/pull/20825
cc @zsxwing
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org