You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ti...@apache.org on 2023/11/11 13:38:54 UTC
svn commit: r1913714 - in /pdfbox/trunk: debugger/src/main/java/org/apache/pdfbox/debugger/ui/ pdfbox/src/main/java/org/apache/pdfbox/pdmodel/fdf/ tools/src/main/java/org/apache/pdfbox/tools/
Author: tilman
Date: Sat Nov 11 13:38:54 2023
New Revision: 1913714
URL: http://svn.apache.org/viewvc?rev=1913714&view=rev
Log:
PDFBOX-5660: remove unnecessary calls to toString() / String.valueOf(), by Axel Howind
Modified:
pdfbox/trunk/debugger/src/main/java/org/apache/pdfbox/debugger/ui/LogDialog.java
pdfbox/trunk/debugger/src/main/java/org/apache/pdfbox/debugger/ui/Tree.java
pdfbox/trunk/debugger/src/main/java/org/apache/pdfbox/debugger/ui/XrefEntry.java
pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/fdf/FDFAnnotation.java
pdfbox/trunk/tools/src/main/java/org/apache/pdfbox/tools/ExtractText.java
pdfbox/trunk/tools/src/main/java/org/apache/pdfbox/tools/PDFText2HTML.java
Modified: pdfbox/trunk/debugger/src/main/java/org/apache/pdfbox/debugger/ui/LogDialog.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/debugger/src/main/java/org/apache/pdfbox/debugger/ui/LogDialog.java?rev=1913714&r1=1913713&r2=1913714&view=diff
==============================================================================
--- pdfbox/trunk/debugger/src/main/java/org/apache/pdfbox/debugger/ui/LogDialog.java (original)
+++ pdfbox/trunk/debugger/src/main/java/org/apache/pdfbox/debugger/ui/LogDialog.java Sat Nov 11 13:38:54 2023
@@ -129,7 +129,7 @@ public class LogDialog extends JDialog
{
StringWriter sw = new StringWriter();
throwable.printStackTrace(new PrintWriter(sw));
- message += "\n " + sw.toString();
+ message += "\n " + sw;
exceptionCount++;
}
Modified: pdfbox/trunk/debugger/src/main/java/org/apache/pdfbox/debugger/ui/Tree.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/debugger/src/main/java/org/apache/pdfbox/debugger/ui/Tree.java?rev=1913714&r1=1913713&r2=1913714&view=diff
==============================================================================
--- pdfbox/trunk/debugger/src/main/java/org/apache/pdfbox/debugger/ui/Tree.java (original)
+++ pdfbox/trunk/debugger/src/main/java/org/apache/pdfbox/debugger/ui/Tree.java Sat Nov 11 13:38:54 2023
@@ -344,7 +344,7 @@ public class Tree extends JTree
nameListBuilder.append(filters.get(i).getName()).append(" & ");
}
nameListBuilder.delete(nameListBuilder.lastIndexOf("&"), nameListBuilder.length());
- JMenuItem menuItem = new JMenuItem("Keep " + nameListBuilder.toString() + "...");
+ JMenuItem menuItem = new JMenuItem("Keep " + nameListBuilder + "...");
menuItem.addActionListener(actionEvent ->
{
Modified: pdfbox/trunk/debugger/src/main/java/org/apache/pdfbox/debugger/ui/XrefEntry.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/debugger/src/main/java/org/apache/pdfbox/debugger/ui/XrefEntry.java?rev=1913714&r1=1913713&r2=1913714&view=diff
==============================================================================
--- pdfbox/trunk/debugger/src/main/java/org/apache/pdfbox/debugger/ui/XrefEntry.java (original)
+++ pdfbox/trunk/debugger/src/main/java/org/apache/pdfbox/debugger/ui/XrefEntry.java Sat Nov 11 13:38:54 2023
@@ -73,7 +73,7 @@ public class XrefEntry
return "(null)";
}
return offset >= 0 ? //
- "Offset: " + offset + " [" + key.toString() + "]" : //
- "Compressed object stream: " + (-offset) + " [" + key.toString() + "]";
+ "Offset: " + offset + " [" + key + "]" : //
+ "Compressed object stream: " + (-offset) + " [" + key + "]";
}
}
Modified: pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/fdf/FDFAnnotation.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/fdf/FDFAnnotation.java?rev=1913714&r1=1913713&r2=1913714&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/fdf/FDFAnnotation.java (original)
+++ pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/fdf/FDFAnnotation.java Sat Nov 11 13:38:54 2023
@@ -1001,7 +1001,6 @@ public abstract class FDFAnnotation impl
builder.append(String.format(" %s=\"%s\"", attribute.getNodeName(),
attributeNodeValue));
}
- return String.format("<%s%s>%s</%s>", node.getNodeName(), builder.toString(),
- sb.toString(), node.getNodeName());
+ return String.format("<%s%s>%s</%s>", node.getNodeName(), builder, sb, node.getNodeName());
}
}
Modified: pdfbox/trunk/tools/src/main/java/org/apache/pdfbox/tools/ExtractText.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/tools/src/main/java/org/apache/pdfbox/tools/ExtractText.java?rev=1913714&r1=1913713&r2=1913714&view=diff
==============================================================================
--- pdfbox/trunk/tools/src/main/java/org/apache/pdfbox/tools/ExtractText.java (original)
+++ pdfbox/trunk/tools/src/main/java/org/apache/pdfbox/tools/ExtractText.java Sat Nov 11 13:38:54 2023
@@ -292,7 +292,7 @@ public final class ExtractText implemen
public void close()
{
// don't close the console
- };
+ }
};
}
else
Modified: pdfbox/trunk/tools/src/main/java/org/apache/pdfbox/tools/PDFText2HTML.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/tools/src/main/java/org/apache/pdfbox/tools/PDFText2HTML.java?rev=1913714&r1=1913713&r2=1913714&view=diff
==============================================================================
--- pdfbox/trunk/tools/src/main/java/org/apache/pdfbox/tools/PDFText2HTML.java (original)
+++ pdfbox/trunk/tools/src/main/java/org/apache/pdfbox/tools/PDFText2HTML.java Sat Nov 11 13:38:54 2023
@@ -239,7 +239,7 @@ public class PDFText2HTML extends PDFTex
builder.append(">");
break;
default:
- builder.append(String.valueOf(character));
+ builder.append(character);
}
}
}