You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@magpie.apache.org by "potiuk (via GitHub)" <gi...@apache.org> on 2026/10/22 23:50:39 UTC
[PR] fix(agent-guard): discover skill guards on a marketplace install [magpie]
potiuk opened a new pull request, #1762:
URL: https://github.com/apache/magpie/pull/1762
A marketplace caches every plugin on its own, as `<marketplace>/<plugin>/<version>/`, so the published `magpie-agent-guard` plugin has no framework tree above it and `framework_root()` returns `None` there.
The skill-owned guards (`mention`, `mark_ready`, `security_language`) were therefore never discovered on a marketplace install — only the bundled `guards.d` ran.
#1757 fixed discovery for checkouts and snapshots; this closes the remaining marketplace case, raised in its review.
## Summary
- New `installed_plugin_guard_dirs()`: when the engine runs from `<marketplace>/magpie-agent-guard/<version>/` (no framework tree), scan `skills/*/guards` of the sibling family plugins in the same cache.
- Version choice: each sibling's copy at the engine's own version (the families are released together), else its most recently installed version.
- A framework checkout or snapshot is unaffected: `framework_root()` still wins, and `plugins/` in a checkout is never mistaken for a plugin cache.
- Plugin copy of the engine synced, isolated-setup fingerprint regenerated, `tools/agent-guard/README.md` and the marketplace-distribution spec updated.
## Test plan
- [x] Four new tests in `tools/agent-guard/tests/test_discovery.py` on a fake plugin cache: siblings discovered, own version preferred over a newer leftover, latest-install fallback, a checkout never scans a cache.
- [x] Full `tools/agent-guard` suite passes.
- [x] `prek` hooks pass on the changed files.
## Gen-AI disclosure
Generated with Claude Code (Claude Opus 5); reviewed by the committer.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@magpie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(agent-guard): discover skill guards on a marketplace install [magpie]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #1762:
URL: https://github.com/apache/magpie/pull/1762
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@magpie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org