You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/05/21 09:14:15 UTC
[GitHub] [spark] zhengruifeng opened a new pull request, #36624: [SPARK-39246][PS] Implement Groupby.skew
zhengruifeng opened a new pull request, #36624:
URL: https://github.com/apache/spark/pull/36624
### What changes were proposed in this pull request?
Implement Groupby.skew
### Why are the changes needed?
for api coverage
### Does this PR introduce _any_ user-facing change?
yes, new api added
```
In [4]: df = ps.DataFrame({"A": [1, 2, 1, 1], "B": [True, False, False, True], "C": [3, 4, 3, 4], "D": ["a", "b", "b", "a"]})
In [5]: df.groupby("A").skew()
Out[5]:
B C
A
1 -1.732051 1.732051
2 NaN NaN
```
### How was this patch tested?
added UT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on pull request #36624: [SPARK-39246][PS] Implement Groupby.skew
Posted by GitBox <gi...@apache.org>.
zhengruifeng commented on PR #36624:
URL: https://github.com/apache/spark/pull/36624#issuecomment-1133823203
Merged to master, thanks @HyukjinKwon for reivewing!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] itholic commented on pull request #36624: [SPARK-39246][PS] Implement Groupby.skew
Posted by GitBox <gi...@apache.org>.
itholic commented on PR #36624:
URL: https://github.com/apache/spark/pull/36624#issuecomment-1134025995
Looks good. Thanks :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on pull request #36624: [SPARK-39246][PS] Implement Groupby.skew
Posted by GitBox <gi...@apache.org>.
zhengruifeng commented on PR #36624:
URL: https://github.com/apache/spark/pull/36624#issuecomment-1133603898
firendly ping @HyukjinKwon @xinrong-databricks @itholic @Yikun Would you mind take a look when you have some time? thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng closed pull request #36624: [SPARK-39246][PS] Implement Groupby.skew
Posted by GitBox <gi...@apache.org>.
zhengruifeng closed pull request #36624: [SPARK-39246][PS] Implement Groupby.skew
URL: https://github.com/apache/spark/pull/36624
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org