You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "xdkxlk (via GitHub)" <gi...@apache.org> on 2023/09/07 06:57:53 UTC

[GitHub] [rocketmq] xdkxlk commented on a diff in pull request #7320: [ISSUE #7319] Optimize fault-tolerant mechanism for sending messages and hot update switch

xdkxlk commented on code in PR #7320:
URL: https://github.com/apache/rocketmq/pull/7320#discussion_r1318164831


##########
client/src/main/java/org/apache/rocketmq/client/latency/LatencyFaultToleranceImpl.java:
##########
@@ -37,6 +37,8 @@ public class LatencyFaultToleranceImpl implements LatencyFaultTolerance<String>
     private int detectTimeout = 200;
     private int detectInterval = 2000;
     private final ThreadLocalIndex whichItemWorst = new ThreadLocalIndex();
+
+    private boolean startDetectorEnable = false;

Review Comment:
   It is better to use volatile here



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org