[GitHub] [arrow] pitrou commented on a change in pull request #8977: ARROW-10675: [C++][Python] Support AWS S3 web identity credentials.

[GitBox <gi...@apache.org>]

pitrou commented on a change in pull request #8977:
URL: https://github.com/apache/arrow/pull/8977#discussion_r551385876



##########
File path: python/pyarrow/_s3fs.pyx
##########
@@ -149,6 +157,8 @@ cdef class S3FileSystem(FileSystem):
             )
         elif anonymous:
             options = CS3Options.Anonymous()
+        elif use_web_identity:
+            options = CS3Options.FromAssumeRoleWithWebIdentity()

Review comment:
       If `use_web_identity`, `anonymous`, `role_arn` and (`access_key` or `secret_key`) are all exclusive, we should probably test for such cases and raise an error.

##########
File path: python/pyarrow/_s3fs.pyx
##########
@@ -82,6 +82,8 @@ cdef class S3FileSystem(FileSystem):
     external_id: str, default None
         An optional unique identifier that might be required when you assume
         a role in another account.
+    use_web_identity: bool, default False
+        ...

Review comment:
       Can you add the argument description here?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org