You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "melloware (via GitHub)" <gi...@apache.org> on 2023/03/05 17:02:02 UTC

[GitHub] [myfaces] melloware opened a new pull request, #544: MYFACES-4581: Felix 5.1.8

melloware opened a new pull request, #544:
URL: https://github.com/apache/myfaces/pull/544

   Fixes ConcurrentModificationException trying to build locally.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [myfaces] tandraschko commented on pull request #544: MYFACES-4581: Felix 5.1.8

Posted by "tandraschko (via GitHub)" <gi...@apache.org>.
tandraschko commented on PR #544:
URL: https://github.com/apache/myfaces/pull/544#issuecomment-1669771592

   any news @volosied?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [myfaces] volosied commented on pull request #544: MYFACES-4581: Felix 5.1.8

Posted by "volosied (via GitHub)" <gi...@apache.org>.
volosied commented on PR #544:
URL: https://github.com/apache/myfaces/pull/544#issuecomment-1458873714

   Building with 5.18 produces the following impl manifest: 
   
   ```
   Import-Package: jakarta.annotation;version="[2.1.0,3.0.0)",
   javax.crypto
   javax.crypto.spec
   jakarta.ejb;version="[4.0.0,5.0.0)";resolution:=optional
   jakarta.el
   javax.naming
   jakarta.persistence;version="[3.1.0,4.0.0)";resolution:=optional
   jakarta.servlet
   jakarta.servlet.http
   jakarta.servlet.annotation;resolution:=optional
   javax.xml.parsers
   ```
   
   But we specify version here: 
   https://github.com/apache/myfaces/blob/main/impl/pom.xml#L632-L646
   
   
   Looks like it still occurs. Let me look at this again. 
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [myfaces] volosied commented on pull request #544: MYFACES-4581: Felix 5.1.8

Posted by "volosied (via GitHub)" <gi...@apache.org>.
volosied commented on PR #544:
URL: https://github.com/apache/myfaces/pull/544#issuecomment-1458908279

   Even updating to the jakarta spec jars doesn't seem to fix the jakarta.el import: 
   
   https://github.com/volosied/myfaces/pull/new/jakarta-dep-update


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [myfaces] melloware commented on pull request #544: MYFACES-4581: Felix 5.1.8

Posted by "melloware (via GitHub)" <gi...@apache.org>.
melloware commented on PR #544:
URL: https://github.com/apache/myfaces/pull/544#issuecomment-1455146675

   @volosied I didn't understand https://issues.apache.org/jira/browse/FELIX-6566 which is still open can you see if version 5.1.8 still has the issue you refer to?  I cannot build 4.0 locally without this plugin upgrade


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] MYFACES-4581: Felix 5.1.8 [myfaces]

Posted by "tandraschko (via GitHub)" <gi...@apache.org>.
tandraschko merged PR #544:
URL: https://github.com/apache/myfaces/pull/544


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] MYFACES-4581: Felix 5.1.8 [myfaces]

Posted by "tandraschko (via GitHub)" <gi...@apache.org>.
tandraschko commented on PR #544:
URL: https://github.com/apache/myfaces/pull/544#issuecomment-1850104276

   i need to merge this for now as all CI are failing.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [myfaces] volosied commented on pull request #544: MYFACES-4581: Felix 5.1.8

Posted by "volosied (via GitHub)" <gi...@apache.org>.
volosied commented on PR #544:
URL: https://github.com/apache/myfaces/pull/544#issuecomment-1460659391

   I'll try to reach out to some more people. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [myfaces] melloware commented on pull request #544: MYFACES-4581: Felix 5.1.8

Posted by "melloware (via GitHub)" <gi...@apache.org>.
melloware commented on PR #544:
URL: https://github.com/apache/myfaces/pull/544#issuecomment-1460799034

   We use Felix 5.1.8 in PrimeFaces too and I don't think we have had issues so this is strange. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [myfaces] melloware commented on pull request #544: MYFACES-4581: Felix 5.1.8

Posted by "melloware (via GitHub)" <gi...@apache.org>.
melloware commented on PR #544:
URL: https://github.com/apache/myfaces/pull/544#issuecomment-1458901251

   OK thanks for looking at this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org