You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/04/26 12:15:10 UTC
[GitHub] [beam] pawelpasterz opened a new pull request #11527: Update error prone plugin
pawelpasterz opened a new pull request #11527:
URL: https://github.com/apache/beam/pull/11527
Update ErrorProne plugin to the latest 1.1.1 version.
That would allow to compile java code with jdk 11 and proceed with further java 11 related tasks.[
Migration from 0.0.xx version](https://github.com/tbroyer/gradle-errorprone-plugin#migration-from-versions-00x)
[JDK 8 support](https://github.com/tbroyer/gradle-errorprone-plugin#migration-from-versions-00x)
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark
--- | --- | --- | --- | --- | --- | --- | ---
Go | [](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/)
Java | [](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Java11/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/)
Python | [](https://builds.apache.org/job/beam_PostCommit_Python2/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python35/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/) | --- | [](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow_V2/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Python2_PVR_Flink_Cron/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python35_VR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Python_VR_Spark/lastCompletedBuild/)
XLang | --- | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_XVR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_XVR_Spark/lastCompletedBuild/)
Pre-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
--- |Java | Python | Go | Website
--- | --- | --- | --- | ---
Non-portable | [](https://builds.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PreCommit_PythonLint_Cron/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/)
Portable | --- | [](https://builds.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/) | --- | ---
See [.test-infra/jenkins/README](https://github.com/apache/beam/blob/master/.test-infra/jenkins/README.md) for trigger phrase, status and link of all Jenkins jobs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pawelpasterz edited a comment on pull request #11527: Update error prone plugin
Posted by GitBox <gi...@apache.org>.
pawelpasterz edited a comment on pull request #11527:
URL: https://github.com/apache/beam/pull/11527#issuecomment-619540364
R: @Ardagan @kennknowles @lukecwik @aaltay
cc: @mwalenia @kamilwu
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pawelpasterz commented on a change in pull request #11527: Update error prone plugin
Posted by GitBox <gi...@apache.org>.
pawelpasterz commented on a change in pull request #11527:
URL: https://github.com/apache/beam/pull/11527#discussion_r419088877
##########
File path: buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
##########
@@ -870,8 +867,19 @@ class BeamModulePlugin implements Plugin<Project> {
// Enable errorprone static analysis
project.apply plugin: 'net.ltgt.errorprone'
+ project.dependencies {
+ errorprone("com.google.errorprone:error_prone_core:2.3.1")
+ errorproneJavac("com.google.errorprone:javac:9+181-r4173-1")
Review comment:
Sure, this version is taken directly from EP plugin documentation, support for JDK 8 section to be specific. I'll add comment with short description and link
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #11527: Update error prone plugin
Posted by GitBox <gi...@apache.org>.
kennknowles commented on pull request #11527:
URL: https://github.com/apache/beam/pull/11527#issuecomment-620685548
@iemejia had some insight last time I tried to do this
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kamilwu commented on pull request #11527: Update error prone plugin
Posted by GitBox <gi...@apache.org>.
kamilwu commented on pull request #11527:
URL: https://github.com/apache/beam/pull/11527#issuecomment-619835330
Retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kamilwu commented on pull request #11527: Update error prone plugin
Posted by GitBox <gi...@apache.org>.
kamilwu commented on pull request #11527:
URL: https://github.com/apache/beam/pull/11527#issuecomment-619852737
Run Website_Stage_GCS PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] iemejia commented on pull request #11527: Update error prone plugin
Posted by GitBox <gi...@apache.org>.
iemejia commented on pull request #11527:
URL: https://github.com/apache/beam/pull/11527#issuecomment-620863411
I am having an amnesia moment about this, trying hard to remember and I cannot even find references on the previous issues, so much time has happened that maybe it is just not an issue anymore, let's see.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pawelpasterz commented on pull request #11527: Update error prone plugin
Posted by GitBox <gi...@apache.org>.
pawelpasterz commented on pull request #11527:
URL: https://github.com/apache/beam/pull/11527#issuecomment-619540364
R: @Ardagan @kennknowles @lukecwik
cc: @mwalenia @kamilwu
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pawelpasterz commented on a change in pull request #11527: Update error prone plugin
Posted by GitBox <gi...@apache.org>.
pawelpasterz commented on a change in pull request #11527:
URL: https://github.com/apache/beam/pull/11527#discussion_r419094426
##########
File path: buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
##########
@@ -870,8 +867,19 @@ class BeamModulePlugin implements Plugin<Project> {
// Enable errorprone static analysis
project.apply plugin: 'net.ltgt.errorprone'
+ project.dependencies {
+ errorprone("com.google.errorprone:error_prone_core:2.3.1")
Review comment:
They (versions) are already different in master but I see no problem to align them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on a change in pull request #11527: Update error prone plugin
Posted by GitBox <gi...@apache.org>.
kennknowles commented on a change in pull request #11527:
URL: https://github.com/apache/beam/pull/11527#discussion_r416718191
##########
File path: buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
##########
@@ -870,8 +867,19 @@ class BeamModulePlugin implements Plugin<Project> {
// Enable errorprone static analysis
project.apply plugin: 'net.ltgt.errorprone'
+ project.dependencies {
+ errorprone("com.google.errorprone:error_prone_core:2.3.1")
+ errorproneJavac("com.google.errorprone:javac:9+181-r4173-1")
Review comment:
This version looks very "interesting". Can you add a comment so someone who sees it can understand what is going on?
##########
File path: buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
##########
@@ -870,8 +867,19 @@ class BeamModulePlugin implements Plugin<Project> {
// Enable errorprone static analysis
project.apply plugin: 'net.ltgt.errorprone'
+ project.dependencies {
+ errorprone("com.google.errorprone:error_prone_core:2.3.1")
Review comment:
Should core and annotations be the same version?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] iemejia commented on pull request #11527: Update error prone plugin
Posted by GitBox <gi...@apache.org>.
iemejia commented on pull request #11527:
URL: https://github.com/apache/beam/pull/11527#issuecomment-623913594
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org