You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "maninc (via GitHub)" <gi...@apache.org> on 2024/02/23 01:12:02 UTC

[PR] Verify field exist in schema before fetching the value [hudi]

maninc opened a new pull request, #10733:
URL: https://github.com/apache/hudi/pull/10733

   ### Change Logs
   - Avro 1.10 throws ```AvroRuntimeException``` when field is not present in the schema. 
   - Since reader schema doesn't contain all fields present in the table. This causes exceptions to be thrown for all fields which are not present in the schema.
   - To fix, Verify the field before trying to fetch the value
   
   ### Impact
   
   - Catching exception and printing log introduces performance impact for MoR RT tables 
   - SELECT query on 3TB TPCDS RT Table with ~40 columns and 10K row updates
   - took ```429739 ms```
   - with fix ```20689 ms```
   
   ### Risk level (write none, low medium or high below)
   _low_
   
   ### Documentation Update
   
   _N/A_
   
   
   ### Contributor's checklist
   
   - [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
   - [ ] Change Logs and Impact were stated clearly
   - [ ] Adequate tests were added if applicable
   - [ ] CI passed
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Verify field exist in schema before fetching the value [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #10733:
URL: https://github.com/apache/hudi/pull/10733#issuecomment-1960613191

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "6ae6e2bdd3a2734076f838a3ddea3d74b1e70abf",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "6ae6e2bdd3a2734076f838a3ddea3d74b1e70abf",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 6ae6e2bdd3a2734076f838a3ddea3d74b1e70abf UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Verify field exist in schema before fetching the value [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #10733:
URL: https://github.com/apache/hudi/pull/10733#issuecomment-1960679890

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "6ae6e2bdd3a2734076f838a3ddea3d74b1e70abf",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22572",
       "triggerID" : "6ae6e2bdd3a2734076f838a3ddea3d74b1e70abf",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 6ae6e2bdd3a2734076f838a3ddea3d74b1e70abf Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22572) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Verify field exist in schema before fetching the value [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #10733:
URL: https://github.com/apache/hudi/pull/10733#issuecomment-1960617859

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "6ae6e2bdd3a2734076f838a3ddea3d74b1e70abf",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22572",
       "triggerID" : "6ae6e2bdd3a2734076f838a3ddea3d74b1e70abf",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 6ae6e2bdd3a2734076f838a3ddea3d74b1e70abf Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22572) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [HUDI-7440] Verify field exist in schema before fetching the value [hudi]

Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 merged PR #10733:
URL: https://github.com/apache/hudi/pull/10733


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org