You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@parquet.apache.org by al...@apache.org on 2015/07/17 01:39:48 UTC
parquet-mr git commit: PARQUET-338: Fix pull request example in README
Repository: parquet-mr
Updated Branches:
refs/heads/master be9f3cb2a -> 8a2c61866
PARQUET-338: Fix pull request example in README
The example PR has the wrong format, it uses [PARQUET-123] instead of PARQUET-123:
Author: Alex Levenson <al...@isnotinvain.com>
Closes #244 from isnotinvain/patch-2 and squashes the following commits:
41aaad2 [Alex Levenson] Fix pull request example in README
Project: http://git-wip-us.apache.org/repos/asf/parquet-mr/repo
Commit: http://git-wip-us.apache.org/repos/asf/parquet-mr/commit/8a2c6186
Tree: http://git-wip-us.apache.org/repos/asf/parquet-mr/tree/8a2c6186
Diff: http://git-wip-us.apache.org/repos/asf/parquet-mr/diff/8a2c6186
Branch: refs/heads/master
Commit: 8a2c6186628da556504dfde803ad660f5280d640
Parents: be9f3cb
Author: Alex Levenson <al...@isnotinvain.com>
Authored: Thu Jul 16 16:39:48 2015 -0700
Committer: Alex Levenson <al...@twitter.com>
Committed: Thu Jul 16 16:39:48 2015 -0700
----------------------------------------------------------------------
README.md | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/parquet-mr/blob/8a2c6186/README.md
----------------------------------------------------------------------
diff --git a/README.md b/README.md
index a34e396..9cf98d4 100644
--- a/README.md
+++ b/README.md
@@ -188,7 +188,7 @@ To contribute a patch:
1. Break your work into small, single-purpose patches if possible. It’s much harder to merge in a large change with a lot of disjoint features.
2. Create a JIRA for your patch on the [Parquet Project JIRA](https://issues.apache.org/jira/browse/PARQUET).
- 3. Submit the patch as a GitHub pull request against the master branch. For a tutorial, see the GitHub guides on forking a repo and sending a pull request. Prefix your pull request name with the JIRA name (ex: https://github.com/apache/parquet-mr/pull/117).
+ 3. Submit the patch as a GitHub pull request against the master branch. For a tutorial, see the GitHub guides on forking a repo and sending a pull request. Prefix your pull request name with the JIRA name (ex: https://github.com/apache/parquet-mr/pull/240).
4. Make sure that your code passes the unit tests. You can run the tests with `mvn test` in the root directory.
5. Add new unit tests for your code.