You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@apr.apache.org by wr...@apache.org on 2006/03/10 23:56:27 UTC

svn commit: r384942 - in /apr/apr/trunk/file_io/unix: filestat.c open.c seek.c

Author: wrowe
Date: Fri Mar 10 14:56:26 2006
New Revision: 384942

URL: http://svn.apache.org/viewcvs?rev=384942&view=rev
Log:

  Identify several mutex-unprotected flushes

Modified:
    apr/apr/trunk/file_io/unix/filestat.c
    apr/apr/trunk/file_io/unix/open.c
    apr/apr/trunk/file_io/unix/seek.c

Modified: apr/apr/trunk/file_io/unix/filestat.c
URL: http://svn.apache.org/viewcvs/apr/apr/trunk/file_io/unix/filestat.c?rev=384942&r1=384941&r2=384942&view=diff
==============================================================================
--- apr/apr/trunk/file_io/unix/filestat.c (original)
+++ apr/apr/trunk/file_io/unix/filestat.c Fri Mar 10 14:56:26 2006
@@ -107,6 +107,7 @@
     struct_stat info;
 
     if (thefile->buffered) {
+        /* XXX: flush here is not mutex protected */
         apr_status_t rv = apr_file_flush(thefile);
         if (rv != APR_SUCCESS)
             return rv;

Modified: apr/apr/trunk/file_io/unix/open.c
URL: http://svn.apache.org/viewcvs/apr/apr/trunk/file_io/unix/open.c?rev=384942&r1=384941&r2=384942&view=diff
==============================================================================
--- apr/apr/trunk/file_io/unix/open.c (original)
+++ apr/apr/trunk/file_io/unix/open.c Fri Mar 10 14:56:26 2006
@@ -32,6 +32,7 @@
     apr_status_t flush_rv = APR_SUCCESS, rv = APR_SUCCESS;
 
     if (file->buffered) {
+        /* XXX: flush here is not mutex protected */
         flush_rv = apr_file_flush(file);
     }
     if (close(file->filedes) == 0) {

Modified: apr/apr/trunk/file_io/unix/seek.c
URL: http://svn.apache.org/viewcvs/apr/apr/trunk/file_io/unix/seek.c?rev=384942&r1=384941&r2=384942&view=diff
==============================================================================
--- apr/apr/trunk/file_io/unix/seek.c (original)
+++ apr/apr/trunk/file_io/unix/seek.c Fri Mar 10 14:56:26 2006
@@ -22,6 +22,7 @@
     apr_status_t rv;
 
     if (thefile->direction == 1) {
+        /* XXX: flush here is not mutex protected */
         rv = apr_file_flush(thefile);
         if (rv) {
             return rv;