You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@activemq.apache.org by sebthom <gi...@git.apache.org> on 2018/10/22 19:21:20 UTC

[GitHub] activemq-artemis pull request #2384: ARTEMIS-2141 Add Filter column to Consu...

GitHub user sebthom opened a pull request:

    https://github.com/apache/activemq-artemis/pull/2384

    ARTEMIS-2141 Add Filter column to Consumers View of AdminUI

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sebthom/activemq-artemis consumers-filter

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/2384.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2384
    
----
commit ff1decdded7778316f8c6c9c1af74646e89c3022
Author: extern-thomschke-sebastian <ex...@...>
Date:   2018-10-22T15:24:04Z

    ARTEMIS-2141 Add Filter column to Consumers View of AdminUI

----


---

[GitHub] activemq-artemis issue #2384: ARTEMIS-2141 Add Filter column to Consumers Vi...

Posted by sebthom <gi...@git.apache.org>.

Github user sebthom commented on the issue:

    https://github.com/apache/activemq-artemis/pull/2384
  
    @michaelandrepearce Thanks for merging the PR! Is there any chance this gets backported/included into 2.6.4?


---

[GitHub] activemq-artemis issue #2384: ARTEMIS-2141 Add Filter column to Consumers Vi...

Posted by michaelandrepearce <gi...@git.apache.org>.

Github user michaelandrepearce commented on the issue:

    https://github.com/apache/activemq-artemis/pull/2384
  
    @sebthom LGTM, thanks for the enhancements and the contribution


---

[GitHub] activemq-artemis issue #2384: ARTEMIS-2141 Add Filter column to Consumers Vi...

Posted by michaelandrepearce <gi...@git.apache.org>.

Github user michaelandrepearce commented on the issue:

    https://github.com/apache/activemq-artemis/pull/2384
  
    Please also update ConsumerFilterPredicate to handle the new field, see QueueFilterPredicate for example of handling filter in the filterpredicates


---

[GitHub] activemq-artemis issue #2384: ARTEMIS-2141 Add Filter column to Consumers Vi...

Posted by sebthom <gi...@git.apache.org>.

Github user sebthom commented on the issue:

    https://github.com/apache/activemq-artemis/pull/2384
  
    @michaelandrepearce I updated the ConsumerFilterPredicate too now and also changed the filter related implementation of the getField() method in ConsumerView according to QueueView.


---

[GitHub] activemq-artemis pull request #2384: ARTEMIS-2141 Add Filter column to Consu...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/activemq-artemis/pull/2384


---

[GitHub] activemq-artemis pull request #2384: ARTEMIS-2141 Add Filter column to Consu...

Posted by michaelandrepearce <gi...@git.apache.org>.

Github user michaelandrepearce commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/2384#discussion_r227607588
  
    --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/management/impl/view/ConsumerView.java ---
    @@ -89,6 +90,8 @@ public Object getField(ServerConsumer consumer, String fieldName) {
                 return consumer.getQueueName();
              case "queueType":
                 return consumer.getQueueType();
    +         case "filter":
    +            return consumer.getFilter() == null ? "" : consumer.getFilter().getFilterString();
    --- End diff --
    
    Rather than the dupe logic here and on line 61, create a method to getFilterString.
    
    Also if null, should return null, not empty string.
             return filter != null ? filter.getFilterString().toString() : null;
    
    e.g. should be same logic as in QueueControlImpl 
    



---