[GitHub] [hbase] joshelser commented on a change in pull request #2400: HBASE-24877 addendum: additional checks to avoid one extra possible race control in the initialize loop

[GitBox <gi...@apache.org>]

joshelser commented on a change in pull request #2400:
URL: https://github.com/apache/hbase/pull/2400#discussion_r493745306



##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java
##########
@@ -618,28 +622,34 @@ private void initialize() {
 
   @Override
   public void startup() {
-    if (this.sourceRunning) {
-      return;
-    }
+    // mark we are running now
     this.sourceRunning = true;
-    //Flag that signalizes uncaught error happening while starting up the source
-    // and a retry should be attempted
-    MutableBoolean retryStartup = new MutableBoolean(true);
-    do {
-      if(retryStartup.booleanValue()) {
-        retryStartup.setValue(false);
-        startupOngoing.set(true);
-        // mark we are running now
-        initThread = new Thread(this::initialize);
-        Threads.setDaemonThreadRunning(initThread,
-          Thread.currentThread().getName() + ".replicationSource," + this.queueId,
-          (t,e) -> {
+    startupOngoing.set(true);
+    initThread = new Thread(this::initialize);
+      Threads.setDaemonThreadRunning(initThread,

Review comment:
       nit: indentation




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org