You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@isis.apache.org by GitBox <gi...@apache.org> on 2022/10/11 10:45:34 UTC
[GitHub] [isis] HeVictor opened a new pull request, #1136: ISIS-3243: fix typos and formatting in simpleapp and contribute docs
HeVictor opened a new pull request, #1136:
URL: https://github.com/apache/isis/pull/1136
This PR fixes some of the typos and formatting issues in these docs that I've come across.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@isis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [isis] andi-huber merged pull request #1136: ISIS-3243: fix typos and formatting in simpleapp and contribute docs
Posted by GitBox <gi...@apache.org>.
andi-huber merged PR #1136:
URL: https://github.com/apache/isis/pull/1136
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@isis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [isis] HeVictor commented on a diff in pull request #1136: ISIS-3243: fix typos and formatting in simpleapp and contribute docs
Posted by GitBox <gi...@apache.org>.
HeVictor commented on code in PR #1136:
URL: https://github.com/apache/isis/pull/1136#discussion_r992160342
##########
starters/adoc/modules/starters/pages/simpleapp.adoc:
##########
@@ -610,9 +613,6 @@ This may be required because the application might otherwise be configured to us
<.> Sets up logging to use the configuration defined in the `log4j2-test.xml` file
-<.> Tests typically inherit from `IsisIntegrationTestAbstract`, which provides some convenience methods to inherit from.
-In this case, the test inherits from the `IsisIntegrationTestAbstractWithFixtures` subclass which also adds in support for running fixtures.
-
=== webapp's src/main/java
Review Comment:
Beyond a couple of typos, I rearranged the numbered annotations for `SimpleModuleIntegTestAbstract.java` in this file as I think they weren't lined up properly with the line of code they were supposed to correspond to. I made some educated guesses and assumptions here so it is possible that these might not be completely correct
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@isis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [isis] HeVictor commented on pull request #1136: ISIS-3243: fix typos and formatting in simpleapp and contribute docs
Posted by GitBox <gi...@apache.org>.
HeVictor commented on PR #1136:
URL: https://github.com/apache/isis/pull/1136#issuecomment-1274556320
@andi-huber Thanks for reviewing my PR so quickly! Incidentally, I'm participating in [Hacktoberfest](https://hacktoberfest.com/about/) at the moment which is an event that encourages people to contribute to open-source projects in October through PR's. Would it be alright for you to add a `hacktoberfest-accepted` label to this PR to count it towards my contribution for the event?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@isis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [isis] andi-huber commented on a diff in pull request #1136: ISIS-3243: fix typos and formatting in simpleapp and contribute docs
Posted by GitBox <gi...@apache.org>.
andi-huber commented on code in PR #1136:
URL: https://github.com/apache/isis/pull/1136#discussion_r992198371
##########
starters/adoc/modules/starters/pages/simpleapp.adoc:
##########
@@ -610,9 +613,6 @@ This may be required because the application might otherwise be configured to us
<.> Sets up logging to use the configuration defined in the `log4j2-test.xml` file
-<.> Tests typically inherit from `IsisIntegrationTestAbstract`, which provides some convenience methods to inherit from.
-In this case, the test inherits from the `IsisIntegrationTestAbstractWithFixtures` subclass which also adds in support for running fixtures.
-
=== webapp's src/main/java
Review Comment:
looks good to me - thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@isis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [isis] andi-huber commented on pull request #1136: ISIS-3243: fix typos and formatting in simpleapp and contribute docs
Posted by GitBox <gi...@apache.org>.
andi-huber commented on PR #1136:
URL: https://github.com/apache/isis/pull/1136#issuecomment-1274566389
there you go
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@isis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org