You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "tisonkun (via GitHub)" <gi...@apache.org> on 2023/04/17 07:31:41 UTC
[GitHub] [pulsar-manager] tisonkun opened a new pull request, #513: build: upgrade deps for building on modern machine
tisonkun opened a new pull request, #513:
URL: https://github.com/apache/pulsar-manager/pull/513
### Verifying this change
- [x] Make sure that the change passes the `./gradlew build` checks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-manager] tisonkun merged pull request #513: build: upgrade deps for building on modern machine
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun merged PR #513:
URL: https://github.com/apache/pulsar-manager/pull/513
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-manager] tisonkun commented on a diff in pull request #513: build: upgrade deps for building on modern machine
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on code in PR #513:
URL: https://github.com/apache/pulsar-manager/pull/513#discussion_r1170195315
##########
front-end/build.gradle:
##########
@@ -18,8 +18,8 @@ plugins {
}
node {
- version = '10.14.1'
- npmVersion = '6.4.1'
+ version = '16.19.1'
Review Comment:
I may do it after 0.4.0 released or we find further blocker to fix :D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-manager] nodece commented on a diff in pull request #513: build: upgrade deps for building on modern machine
Posted by "nodece (via GitHub)" <gi...@apache.org>.
nodece commented on code in PR #513:
URL: https://github.com/apache/pulsar-manager/pull/513#discussion_r1168984843
##########
front-end/build.gradle:
##########
@@ -18,8 +18,8 @@ plugins {
}
node {
- version = '10.14.1'
- npmVersion = '6.4.1'
+ version = '16.19.1'
Review Comment:
Or use the 18.16 LTS version?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-manager] tisonkun commented on pull request #513: build: upgrade deps for building on modern machine
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on PR #513:
URL: https://github.com/apache/pulsar-manager/pull/513#issuecomment-1513343857
Merging...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-manager] nicoloboschi commented on a diff in pull request #513: build: upgrade deps for building on modern machine
Posted by "nicoloboschi (via GitHub)" <gi...@apache.org>.
nicoloboschi commented on code in PR #513:
URL: https://github.com/apache/pulsar-manager/pull/513#discussion_r1168878728
##########
README.md:
##########
@@ -228,12 +228,12 @@ Use the default account (`pulsar`) and the default password (`pulsar`) to log in
### Configure environment
-The puslar-manager supports multiple environment configurations and can manage multiple environments conveniently.
+The puslar-manager supports multiple environment configurations and can manage multiple environments conveniently.
Review Comment:
```suggestion
The pulsar-manager supports multiple environment configurations and can manage multiple environments conveniently.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-manager] tisonkun commented on a diff in pull request #513: build: upgrade deps for building on modern machine
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on code in PR #513:
URL: https://github.com/apache/pulsar-manager/pull/513#discussion_r1168893877
##########
README.md:
##########
@@ -228,12 +228,12 @@ Use the default account (`pulsar`) and the default password (`pulsar`) to log in
### Configure environment
-The puslar-manager supports multiple environment configurations and can manage multiple environments conveniently.
+The puslar-manager supports multiple environment configurations and can manage multiple environments conveniently.
Review Comment:
Good catch! Updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-manager] tisonkun commented on pull request #513: build: upgrade deps for building on modern machine
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on PR #513:
URL: https://github.com/apache/pulsar-manager/pull/513#issuecomment-1511660804
Pending to merge...
I'm going to prepare a 0.4.0 release candidate tomorrow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org