[GitHub] [iceberg] findepi commented on a diff in pull request #6474: Make it explicit that metrics reporter is required

[GitBox <gi...@apache.org>]

findepi commented on code in PR #6474:
URL: https://github.com/apache/iceberg/pull/6474#discussion_r1066995039


##########
core/src/main/java/org/apache/iceberg/BaseTable.java:
##########
@@ -48,6 +49,7 @@ public BaseTable(TableOperations ops, String name) {
   }
 
   public BaseTable(TableOperations ops, String name, MetricsReporter reporter) {
+    Preconditions.checkNotNull(reporter, "reporter cannot be null");

Review Comment:
   > Also we generally use `Preconditions.checkArgument` more than `Preconditions.checkNotNull`:
   
   do we use it commonly to check for nullness?
   
   i think in the code i've contributed so far to iceberg i used cNN and don't remember being turned around to use cA



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org