You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/03/09 10:35:02 UTC

[GitHub] [skywalking] kezhenxu94 opened a new pull request #4471: [BugFix] Docker so11y cannot be disabled

kezhenxu94 opened a new pull request #4471: [BugFix] Docker so11y cannot be disabled
URL: https://github.com/apache/skywalking/pull/4471
 
 
   ### Motivation:
   
   This patch fixes the bug that there's no chance to disable the so11y in docker container.
   
   ### Modifications:
   
   - Remove the default so11y section, and only add it when the environment variable exists.
   
   ### Result:
   
   - Users can disable so11y by leaving the `SW_TELEMETRY` empty or set it to `none`
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] kezhenxu94 merged pull request #4471: [BugFix] Docker so11y cannot be disabled

Posted by GitBox <gi...@apache.org>.
kezhenxu94 merged pull request #4471: [BugFix] Docker so11y cannot be disabled
URL: https://github.com/apache/skywalking/pull/4471
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] hanahmily commented on a change in pull request #4471: [BugFix] Docker so11y cannot be disabled

Posted by GitBox <gi...@apache.org>.
hanahmily commented on a change in pull request #4471: [BugFix] Docker so11y cannot be disabled
URL: https://github.com/apache/skywalking/pull/4471#discussion_r389580820
 
 

 ##########
 File path: docker/oap-es7/docker-entrypoint.sh
 ##########
 @@ -384,8 +384,6 @@ receiver-jvm:
   default:
 receiver-clr:
   default:
-receiver-so11y:
 
 Review comment:
   should move it to func `generateTelemetrySo11y `

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #4471: [BugFix] Docker so11y cannot be disabled

Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #4471: [BugFix] Docker so11y cannot be disabled
URL: https://github.com/apache/skywalking/pull/4471#discussion_r389591000
 
 

 ##########
 File path: docker/oap-es7/docker-entrypoint.sh
 ##########
 @@ -384,8 +384,6 @@ receiver-jvm:
   default:
 receiver-clr:
   default:
-receiver-so11y:
 
 Review comment:
   It's already there, isn't it?
   
   https://github.com/apache/skywalking/blob/5eba81e1409ca11204812bd456d4f4af206b76d2/docker/oap/docker-entrypoint.sh#L450-L454

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] hanahmily commented on a change in pull request #4471: [BugFix] Docker so11y cannot be disabled

Posted by GitBox <gi...@apache.org>.
hanahmily commented on a change in pull request #4471: [BugFix] Docker so11y cannot be disabled
URL: https://github.com/apache/skywalking/pull/4471#discussion_r389616046
 
 

 ##########
 File path: docker/oap-es7/docker-entrypoint.sh
 ##########
 @@ -384,8 +384,6 @@ receiver-jvm:
   default:
 receiver-clr:
   default:
-receiver-so11y:
 
 Review comment:
   sorry, didn't notice it

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services