You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Jesse Wilson (JIRA)" <ji...@apache.org> on 2009/06/11 23:39:07 UTC
[jira] Created: (HARMONY-6230) ZipEntry close() leaves
ZipInputStream in an inconsistent state
ZipEntry close() leaves ZipInputStream in an inconsistent state
---------------------------------------------------------------
Key: HARMONY-6230
URL: https://issues.apache.org/jira/browse/HARMONY-6230
Project: Harmony
Issue Type: Bug
Components: Classlib
Environment: SVN Revision: 777222
Reporter: Jesse Wilson
closeEntry() leaves the ZipInputStream in an inconsistent state
getNextEntry() doesn't throw when the stream is closed
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-6230) ZipEntry close() leaves
ZipInputStream in an inconsistent state
Posted by "Jesse Wilson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12718649#action_12718649 ]
Jesse Wilson commented on HARMONY-6230:
---------------------------------------
Note: this issue was originally discovered in the downstream Android class libraries! We have tracking bugs for this as well.
> ZipEntry close() leaves ZipInputStream in an inconsistent state
> ---------------------------------------------------------------
>
> Key: HARMONY-6230
> URL: https://issues.apache.org/jira/browse/HARMONY-6230
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Environment: SVN Revision: 777222
> Reporter: Jesse Wilson
> Attachments: ZipInputStreamBugs.patch
>
> Original Estimate: 0.5h
> Remaining Estimate: 0.5h
>
> closeEntry() leaves the ZipInputStream in an inconsistent state
> getNextEntry() doesn't throw when the stream is closed
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-6230) ZipEntry close() leaves
ZipInputStream in an inconsistent state
Posted by "Jesse Wilson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jesse Wilson updated HARMONY-6230:
----------------------------------
Attachment: ZipInputStreamBugs_2.patch
The attached tests require sample jar files to decompress: Broken_entry.jar and Broken_manifest.jar. I'd forgotten to include these files in the first patch, but they're in this one.
> ZipEntry close() leaves ZipInputStream in an inconsistent state
> ---------------------------------------------------------------
>
> Key: HARMONY-6230
> URL: https://issues.apache.org/jira/browse/HARMONY-6230
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Environment: SVN Revision: 777222
> Reporter: Jesse Wilson
> Assignee: Tim Ellison
> Attachments: ZipInputStreamBugs.patch, ZipInputStreamBugs_2.patch
>
> Original Estimate: 0.5h
> Remaining Estimate: 0.5h
>
> closeEntry() leaves the ZipInputStream in an inconsistent state
> getNextEntry() doesn't throw when the stream is closed
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (HARMONY-6230) [classlib][archive] ZipEntry close()
leaves ZipInputStream in an inconsistent state
Posted by "Jesse Wilson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jesse Wilson closed HARMONY-6230.
---------------------------------
Looks good to me.
> [classlib][archive] ZipEntry close() leaves ZipInputStream in an inconsistent state
> -----------------------------------------------------------------------------------
>
> Key: HARMONY-6230
> URL: https://issues.apache.org/jira/browse/HARMONY-6230
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Environment: SVN Revision: 777222
> Reporter: Jesse Wilson
> Assignee: Tim Ellison
> Fix For: 5.0M11
>
> Attachments: Broken_entry.jar, Broken_manifest.jar, ZipInputStreamBugs.patch, ZipInputStreamBugs_2.patch
>
> Original Estimate: 0.5h
> Remaining Estimate: 0.5h
>
> closeEntry() leaves the ZipInputStream in an inconsistent state
> getNextEntry() doesn't throw when the stream is closed
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-6230) ZipEntry close() leaves
ZipInputStream in an inconsistent state
Posted by "Jesse Wilson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jesse Wilson updated HARMONY-6230:
----------------------------------
Attachment: Broken_manifest.jar
Broken_entry.jar
My IDE is having problems generating a .patch that includes a binary file, so I'm attaching them directly. Both files belong in:
working_classlib/support/src/test/java/tests/resources
> ZipEntry close() leaves ZipInputStream in an inconsistent state
> ---------------------------------------------------------------
>
> Key: HARMONY-6230
> URL: https://issues.apache.org/jira/browse/HARMONY-6230
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Environment: SVN Revision: 777222
> Reporter: Jesse Wilson
> Assignee: Tim Ellison
> Attachments: Broken_entry.jar, Broken_manifest.jar, ZipInputStreamBugs.patch, ZipInputStreamBugs_2.patch
>
> Original Estimate: 0.5h
> Remaining Estimate: 0.5h
>
> closeEntry() leaves the ZipInputStream in an inconsistent state
> getNextEntry() doesn't throw when the stream is closed
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HARMONY-6230) [classlib][archive] ZipEntry
close() leaves ZipInputStream in an inconsistent state
Posted by "Tim Ellison (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tim Ellison resolved HARMONY-6230.
----------------------------------
Resolution: Fixed
Fix Version/s: 5.0M11
Thanks Jesse.
Patch applied to ARCHIVE module and SUPPORT module at repo revision r785124.
Please check it was applied as you expected.
> [classlib][archive] ZipEntry close() leaves ZipInputStream in an inconsistent state
> -----------------------------------------------------------------------------------
>
> Key: HARMONY-6230
> URL: https://issues.apache.org/jira/browse/HARMONY-6230
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Environment: SVN Revision: 777222
> Reporter: Jesse Wilson
> Assignee: Tim Ellison
> Fix For: 5.0M11
>
> Attachments: Broken_entry.jar, Broken_manifest.jar, ZipInputStreamBugs.patch, ZipInputStreamBugs_2.patch
>
> Original Estimate: 0.5h
> Remaining Estimate: 0.5h
>
> closeEntry() leaves the ZipInputStream in an inconsistent state
> getNextEntry() doesn't throw when the stream is closed
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-6230) [classlib][archive] ZipEntry close()
leaves ZipInputStream in an inconsistent state
Posted by "Tim Ellison (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tim Ellison updated HARMONY-6230:
---------------------------------
Summary: [classlib][archive] ZipEntry close() leaves ZipInputStream in an inconsistent state (was: ZipEntry close() leaves ZipInputStream in an inconsistent state)
> [classlib][archive] ZipEntry close() leaves ZipInputStream in an inconsistent state
> -----------------------------------------------------------------------------------
>
> Key: HARMONY-6230
> URL: https://issues.apache.org/jira/browse/HARMONY-6230
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Environment: SVN Revision: 777222
> Reporter: Jesse Wilson
> Assignee: Tim Ellison
> Attachments: Broken_entry.jar, Broken_manifest.jar, ZipInputStreamBugs.patch, ZipInputStreamBugs_2.patch
>
> Original Estimate: 0.5h
> Remaining Estimate: 0.5h
>
> closeEntry() leaves the ZipInputStream in an inconsistent state
> getNextEntry() doesn't throw when the stream is closed
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HARMONY-6230) ZipEntry close() leaves
ZipInputStream in an inconsistent state
Posted by "Tim Ellison (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tim Ellison reassigned HARMONY-6230:
------------------------------------
Assignee: Tim Ellison
> ZipEntry close() leaves ZipInputStream in an inconsistent state
> ---------------------------------------------------------------
>
> Key: HARMONY-6230
> URL: https://issues.apache.org/jira/browse/HARMONY-6230
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Environment: SVN Revision: 777222
> Reporter: Jesse Wilson
> Assignee: Tim Ellison
> Attachments: ZipInputStreamBugs.patch
>
> Original Estimate: 0.5h
> Remaining Estimate: 0.5h
>
> closeEntry() leaves the ZipInputStream in an inconsistent state
> getNextEntry() doesn't throw when the stream is closed
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-6230) ZipEntry close() leaves
ZipInputStream in an inconsistent state
Posted by "Tim Ellison (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12719439#action_12719439 ]
Tim Ellison commented on HARMONY-6230:
--------------------------------------
After applying this patch I get:
java.lang.NullPointerException
at tests.support.resource.Support_Resources.copyLocalFileto(Support_Resources.java:118)
at tests.support.resource.Support_Resources.copyFile(Support_Resources.java:98)
at org.apache.harmony.archive.tests.java.util.zip.ZipInputStreamTest.test_closeAfterException(ZipInputStreamTest.java:118)
at java.lang.reflect.AccessibleObject.invokeV(AccessibleObject.java:25)
(Not looked into the cause yet)
> ZipEntry close() leaves ZipInputStream in an inconsistent state
> ---------------------------------------------------------------
>
> Key: HARMONY-6230
> URL: https://issues.apache.org/jira/browse/HARMONY-6230
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Environment: SVN Revision: 777222
> Reporter: Jesse Wilson
> Assignee: Tim Ellison
> Attachments: ZipInputStreamBugs.patch
>
> Original Estimate: 0.5h
> Remaining Estimate: 0.5h
>
> closeEntry() leaves the ZipInputStream in an inconsistent state
> getNextEntry() doesn't throw when the stream is closed
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-6230) ZipEntry close() leaves
ZipInputStream in an inconsistent state
Posted by "Jesse Wilson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jesse Wilson updated HARMONY-6230:
----------------------------------
Attachment: ZipInputStreamBugs.patch
Tests + Fixes.
Without the fix, the tests pass on the RI but fail on Hy.
With the fix, they pass on both class libraries.
> ZipEntry close() leaves ZipInputStream in an inconsistent state
> ---------------------------------------------------------------
>
> Key: HARMONY-6230
> URL: https://issues.apache.org/jira/browse/HARMONY-6230
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Environment: SVN Revision: 777222
> Reporter: Jesse Wilson
> Attachments: ZipInputStreamBugs.patch
>
> Original Estimate: 0.5h
> Remaining Estimate: 0.5h
>
> closeEntry() leaves the ZipInputStream in an inconsistent state
> getNextEntry() doesn't throw when the stream is closed
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.