You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/12/10 19:04:13 UTC

[GitHub] [incubator-superset] codecov-io commented on pull request #12003: chore: remove generic type

codecov-io commented on pull request #12003:
URL: https://github.com/apache/incubator-superset/pull/12003#issuecomment-742729872


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=h1) Report
   > Merging [#12003](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=desc) (193ac0f) into [master](https://codecov.io/gh/apache/incubator-superset/commit/9256b6fb3dcd58cc0956d07c0e947a4f87fbe737?el=desc) (9256b6f) will **decrease** coverage by `0.85%`.
   > The diff coverage is `50.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/12003/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #12003      +/-   ##
   ==========================================
   - Coverage   63.59%   62.73%   -0.86%     
   ==========================================
     Files         940      473     -467     
     Lines       45575    16999   -28576     
     Branches     4373     4373              
   ==========================================
   - Hits        28984    10665   -18319     
   + Misses      16415     6158   -10257     
     Partials      176      176              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | javascript | `62.73% <50.00%> (ø)` | |
   | python | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset-frontend/src/views/CRUD/hooks.ts](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvaG9va3MudHM=) | `57.23% <33.33%> (ø)` | |
   | [...rset-frontend/src/components/ImportModal/index.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSW1wb3J0TW9kYWwvaW5kZXgudHN4) | `74.24% <100.00%> (ø)` | |
   | [superset/migrations/versions/705732c70154\_.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy83MDU3MzJjNzAxNTRfLnB5) | | |
   | [superset/security/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkvX19pbml0X18ucHk=) | | |
   | [superset/examples/multi\_line.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvbXVsdGlfbGluZS5weQ==) | | |
   | [superset/css\_templates/commands/bulk\_delete.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY3NzX3RlbXBsYXRlcy9jb21tYW5kcy9idWxrX2RlbGV0ZS5weQ==) | | |
   | [superset/dataframe.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWZyYW1lLnB5) | | |
   | [superset/reports/logs/api.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9sb2dzL2FwaS5weQ==) | | |
   | [superset/databases/commands/test\_connection.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3Rlc3RfY29ubmVjdGlvbi5weQ==) | | |
   | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | | |
   | ... and [459 more](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=footer). Last update [9256b6f...193ac0f](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org