Re: svn commit: r36230 - in trunk/subversion: include libsvn_subr tests/libsvn_subr

[Greg Stein <gs...@gmail.com>]

On Sun, Mar 1, 2009 at 23:19, Bert Huijben <rh...@sharpsvn.net> wrote:
>...
> +++ trunk/subversion/include/svn_dirent_uri.h   Sun Mar  1 14:19:57 2009        (r36230)
> @@ -134,6 +134,30 @@ svn_dirent_join_many(apr_pool_t *pool,
>                      const char *base,
>                      ...);
>
> +/** Join a base uri (@a base) with a component (@a component), allocating
> + * the result in @a pool. @a component need not be a single component: it
> + * can be any uri, absolute or relative to @a base.
> + *
> + * If either @a base or @a component is the empty path, then the other
> + * argument will be copied and returned.  If both are the empty path the
> + * empty path is returned.
> + *
> + * If the @a component is an absolute uri, then it is copied and returned.
> + *
> + * It @a component starts with a '/' and @a base contains a scheme, the
> + * scheme defined joining rules are applied.
> + *
> + * Exactly one slash character ('/') is used to join the components,
> + * accounting for any trailing slash in @a base.

This phrase is misleading. Canonical URIs do not have trailing slashes
*except* for "/". The above phrase makes it seem legal to pass in a
base with a trailing slash, but that will cause an assertion.

Cheers,
-g

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1255701