You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues-all@impala.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2023/11/02 00:04:00 UTC
[jira] [Commented] (IMPALA-12532) change_database should happen before set_configuration in cancel_util.py
[ https://issues.apache.org/jira/browse/IMPALA-12532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17781938#comment-17781938 ]
ASF subversion and git services commented on IMPALA-12532:
----------------------------------------------------------
Commit fef3564248208fca2e420df98b96dd5b5335894f in impala's branch refs/heads/master from Riza Suminto
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=fef356424 ]
IMPALA-12532: Fix bug in cancel_query_and_validate_state
test_cancellation.py was silently buggy for not exercising exec_option
combinations configured at TestCancellation::execute_cancel_test().
change_database() should not be called right after set_configuration()
in cancel_util.py::cancel_query_and_validate_state(). This is because
change_database() will erase all configuration that was previously set.
This patch fix the issue by calling change_database() first before
set_configuration(). Similar pattern also fixed in
test_admission_controller.py.
Testing:
- Manually run test_cancellation.py and confirm at coordinator log that
query options are set properly.
Change-Id: Ie908fc1384279482892c3f8b2cfa3592e54f9d5a
Reviewed-on: http://gerrit.cloudera.org:8080/20641
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
> change_database should happen before set_configuration in cancel_util.py
> ------------------------------------------------------------------------
>
> Key: IMPALA-12532
> URL: https://issues.apache.org/jira/browse/IMPALA-12532
> Project: IMPALA
> Issue Type: Bug
> Components: Infrastructure
> Affects Versions: Impala 4.3.0
> Reporter: Riza Suminto
> Assignee: Riza Suminto
> Priority: Major
>
> The order of these two lines need to be flipped.
> [https://github.com/apache/impala/blob/d9f1271c96393245c3022129603d1080b206addc/tests/util/cancel_util.py#L34-L35]
> This is because change_database will erase all configuration that was previously set.
> [https://github.com/apache/impala/blob/d9f1271c96393245c3022129603d1080b206addc/tests/common/impala_test_suite.py#L845]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org