[GitHub] [incubator-iceberg] rdsr commented on issue #851: IcebergGenerics should support ORC format

[GitBox <gi...@apache.org>]

rdsr commented on issue #851: IcebergGenerics should support ORC format
URL: https://github.com/apache/incubator-iceberg/pull/851#issuecomment-601217516
 
 
   @leoluan2009 would it make sense to have tests for it.
   Iceberg already has a few tests written for IcebergGenerics which work on Parquet and Avro. Maybe all we need to do it enable it for ORC as well?
   
   The class I'm talking about is `org.apache.iceberg.data.TestLocalScan`. It currently supports Avro, and Parquet like so
   ```
    @Parameterized.Parameters
     public static Object[][] parameters() {
       return new Object[][] {
           new Object[] { "parquet" },
           new Object[] { "avro" }
       };
     }
   ```
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org