You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "slawekjaranowski (via GitHub)" <gi...@apache.org> on 2024/12/07 12:04:15 UTC
[PR] [MCHANGES-454] Deprecate track integration [maven-changes-plugin]
slawekjaranowski opened a new pull request, #94:
URL: https://github.com/apache/maven-changes-plugin/pull/94
https://issues.apache.org/jira/browse/MCHANGES-454
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MCHANGES-454] Deprecate track integration [maven-changes-plugin]
Posted by "michael-o (via GitHub)" <gi...@apache.org>.
michael-o commented on code in PR #94:
URL: https://github.com/apache/maven-changes-plugin/pull/94#discussion_r1874409051
##########
src/main/java/org/apache/maven/plugins/changes/announcement/AnnouncementMojo.java:
##########
@@ -477,6 +477,7 @@ public void execute() throws MojoExecutionException {
}
if (issueManagementSystems.contains(TRAC)) {
+ getLog().warn("TRACT integration is prepared for remove in next major version, lack of maintainers");
Review Comment:
Tractor 🚜
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MCHANGES-454] Deprecate Trac integration [maven-changes-plugin]
Posted by "elharo (via GitHub)" <gi...@apache.org>.
elharo commented on code in PR #94:
URL: https://github.com/apache/maven-changes-plugin/pull/94#discussion_r1874406303
##########
src/main/java/org/apache/maven/plugins/changes/trac/TracChangesReport.java:
##########
@@ -41,7 +41,9 @@
* @author Noriko Kinugasa
* @version $Id$
* @since 2.1
+ * @deprecated prepared for remove in next major version, lack of maintainers
Review Comment:
remove --> removal
##########
src/site/apt/index.apt.vm:
##########
@@ -105,6 +105,10 @@ ${project.name}
| trac-report -> trac-changes | trac-report.html -> trac-changes.html |
*---------------------------------+-------------------------------------------+
+** Deprecate Trac integration
+
+ <<Trac>> integration is prepared for remove in next major version, lack of maintainers.
Review Comment:
removal
version due to lack
##########
src/main/java/org/apache/maven/plugins/changes/announcement/AnnouncementMojo.java:
##########
@@ -477,6 +477,7 @@ public void execute() throws MojoExecutionException {
}
if (issueManagementSystems.contains(TRAC)) {
+ getLog().warn("Trac integration is prepared for remove in next major version, lack of maintainers");
Review Comment:
remove --> removal
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MCHANGES-454] Deprecate track integration [maven-changes-plugin]
Posted by "pzygielo (via GitHub)" <gi...@apache.org>.
pzygielo commented on code in PR #94:
URL: https://github.com/apache/maven-changes-plugin/pull/94#discussion_r1874409245
##########
src/main/java/org/apache/maven/plugins/changes/announcement/AnnouncementMojo.java:
##########
@@ -477,6 +477,7 @@ public void execute() throws MojoExecutionException {
}
if (issueManagementSystems.contains(TRAC)) {
+ getLog().warn("TRACT integration is prepared for remove in next major version, lack of maintainers");
Review Comment:
Please fix the PR title as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MCHANGES-454] Deprecate Trac integration [maven-changes-plugin]
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski merged PR #94:
URL: https://github.com/apache/maven-changes-plugin/pull/94
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MCHANGES-454] Deprecate TRAC integration [maven-changes-plugin]
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on code in PR #94:
URL: https://github.com/apache/maven-changes-plugin/pull/94#discussion_r1874409797
##########
src/main/java/org/apache/maven/plugins/changes/announcement/AnnouncementMojo.java:
##########
@@ -477,6 +477,7 @@ public void execute() throws MojoExecutionException {
}
if (issueManagementSystems.contains(TRAC)) {
+ getLog().warn("TRACT integration is prepared for remove in next major version, lack of maintainers");
Review Comment:
summary - jira, pr and commit also fixed 😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MCHANGES-454] Deprecate Trac integration [maven-changes-plugin]
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on code in PR #94:
URL: https://github.com/apache/maven-changes-plugin/pull/94#discussion_r1874410872
##########
src/main/java/org/apache/maven/plugins/changes/announcement/AnnouncementMojo.java:
##########
@@ -477,6 +477,7 @@ public void execute() throws MojoExecutionException {
}
if (issueManagementSystems.contains(TRAC)) {
+ getLog().warn("TRACT integration is prepared for remove in next major version, lack of maintainers");
Review Comment:
I like a code review even with simple task ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MCHANGES-454] Deprecate track integration [maven-changes-plugin]
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on code in PR #94:
URL: https://github.com/apache/maven-changes-plugin/pull/94#discussion_r1874407728
##########
src/main/java/org/apache/maven/plugins/changes/announcement/AnnouncementMojo.java:
##########
@@ -477,6 +477,7 @@ public void execute() throws MojoExecutionException {
}
if (issueManagementSystems.contains(TRAC)) {
+ getLog().warn("TRACT integration is prepared for remove in next major version, lack of maintainers");
Review Comment:
should be `TRAC` 😄 fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MCHANGES-454] Deprecate track integration [maven-changes-plugin]
Posted by "elharo (via GitHub)" <gi...@apache.org>.
elharo commented on code in PR #94:
URL: https://github.com/apache/maven-changes-plugin/pull/94#discussion_r1874406275
##########
src/main/java/org/apache/maven/plugins/changes/announcement/AnnouncementMojo.java:
##########
@@ -477,6 +477,7 @@ public void execute() throws MojoExecutionException {
}
if (issueManagementSystems.contains(TRAC)) {
+ getLog().warn("TRACT integration is prepared for remove in next major version, lack of maintainers");
Review Comment:
TRAC, TRACT, or Track?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MCHANGES-454] Deprecate TRAC integration [maven-changes-plugin]
Posted by "michael-o (via GitHub)" <gi...@apache.org>.
michael-o commented on code in PR #94:
URL: https://github.com/apache/maven-changes-plugin/pull/94#discussion_r1874409871
##########
src/main/java/org/apache/maven/plugins/changes/announcement/AnnouncementMojo.java:
##########
@@ -477,6 +477,7 @@ public void execute() throws MojoExecutionException {
}
if (issueManagementSystems.contains(TRAC)) {
+ getLog().warn("TRACT integration is prepared for remove in next major version, lack of maintainers");
Review Comment:
It is Trac
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MCHANGES-454] Deprecate Trac integration [maven-changes-plugin]
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on code in PR #94:
URL: https://github.com/apache/maven-changes-plugin/pull/94#discussion_r1874416323
##########
src/site/apt/index.apt.vm:
##########
@@ -105,6 +105,10 @@ ${project.name}
| trac-report -> trac-changes | trac-report.html -> trac-changes.html |
*---------------------------------+-------------------------------------------+
+** Deprecate Trac integration
+
+ <<Trac>> integration is prepared for remove in next major version, lack of maintainers.
Review Comment:
@elharo last suggestions fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org