You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/05/21 18:35:49 UTC

[GitHub] [beam] udim commented on a change in pull request #11661: [BEAM-7774] Remove perfkit benchmarking tool from python performance …

udim commented on a change in pull request #11661:
URL: https://github.com/apache/beam/pull/11661#discussion_r428838484



##########
File path: sdks/python/test-suites/dataflow/common.gradle
##########
@@ -109,4 +109,21 @@ task validatesRunnerStreamingTests {
       args '-c', ". ${envdir}/bin/activate && ${runScriptsDir}/run_integration_test.sh $cmdArgs"
     }
   }
-}
\ No newline at end of file
+}
+
+task runPerformanceTest {
+    dependsOn 'installGcpTest'
+    dependsOn ':sdks:python:sdist'
+
+    def test = project.findProperty('test')
+    def testOpts = project.findProperty('test-pipeline-options')
+    testOpts += " --sdk_location=${files(configurations.distTarBall.files).singleFile}"
+
+  doLast {
+    exec {
+      workingDir "${project.rootDir}/sdks/python"
+      executable 'sh'
+      args '-c', ". ${envdir}/bin/activate && ${envdir}/bin/python setup.py nosetests --tests=${test}  --test-pipeline-options=\"${testOpts}\" --ignore-files \'.*py3\\d?\\.py\$\'"

Review comment:
       I don't believe we have `--test-pipeline-options` support yet in pytest, so nose is the solution for now.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org