You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by bhavya411 <gi...@git.apache.org> on 2017/02/28 12:24:57 UTC
[GitHub] incubator-carbondata pull request #616: [CARBONDATA-708] Fixed Between Filte...
GitHub user bhavya411 opened a pull request:
https://github.com/apache/incubator-carbondata/pull/616
[CARBONDATA-708] Fixed Between Filter Issue for Pushed Filters in case it was applied \u2026
Fixed Between Filter Issue for Pushed Filters in case it was applied on Dimension
Test
Add Examples of Between Filter
Removed Scalastyle
Manually Test BETWEEN Filter
Run Unit Test Cases
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bhavya411/incubator-carbondata CARBONDATA-708
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-carbondata/pull/616.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #616
----
commit 1f537953419e7201bb314492656bf58a9a335546
Author: Bhavya <bh...@knoldus.com>
Date: 2017-02-28T12:19:21Z
Fixed Between Filter Issue for Pushed Filters in case it was applied on Dimension
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata issue #616: [CARBONDATA-708] Fixed Between Filter Issue...
Posted by bhavya411 <gi...@git.apache.org>.
Github user bhavya411 commented on the issue:
https://github.com/apache/incubator-carbondata/pull/616
I have rebased the code
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata pull request #616: [CARBONDATA-708] Fixed Between Filte...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/616#discussion_r105885093
--- Diff: integration/spark2/src/main/scala/org/apache/carbondata/spark/CarbonFilters.scala ---
@@ -110,8 +110,16 @@ object CarbonFilters {
}
def getCarbonLiteralExpression(name: String, value: Any): CarbonExpression = {
- new CarbonLiteralExpression(value,
- CarbonScalaUtil.convertSparkToCarbonDataType(dataTypeOf(name)))
+ val dataTypeOfAttribute = CarbonScalaUtil.convertSparkToCarbonDataType(dataTypeOf(name))
+ val dataType = if (Option(value).isDefined
+ && dataTypeOfAttribute == DataType.STRING
+ && value.isInstanceOf[Double]) {
--- End diff --
Can you explain with out this fix what is the issue happening?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata issue #616: [CARBONDATA-708] Fixed Between Filter Issue...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/incubator-carbondata/pull/616
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata issue #616: [CARBONDATA-708] Fixed Between Filter Issue...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/incubator-carbondata/pull/616
Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1139/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata issue #616: [CARBONDATA-708] Fixed Between Filter Issue...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/incubator-carbondata/pull/616
Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/985/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata pull request #616: [CARBONDATA-708] Fixed Between Filte...
Posted by bhavya411 <gi...@git.apache.org>.
Github user bhavya411 closed the pull request at:
https://github.com/apache/incubator-carbondata/pull/616
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata issue #616: [CARBONDATA-708] Fixed Between Filter Issue...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/incubator-carbondata/pull/616
Build Failed with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1304/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata issue #616: [CARBONDATA-708] Fixed Between Filter Issue...
Posted by chenliang613 <gi...@git.apache.org>.
Github user chenliang613 commented on the issue:
https://github.com/apache/incubator-carbondata/pull/616
add to whitelist
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata issue #616: [CARBONDATA-708] Fixed Between Filter Issue...
Posted by bhavya411 <gi...@git.apache.org>.
Github user bhavya411 commented on the issue:
https://github.com/apache/incubator-carbondata/pull/616
@ravipesala Created a New PR #697 for the fixes that were suggested , added a Unit test class to make sure it runs everytime with the build and removed the example
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata issue #616: [CARBONDATA-708] Fixed Between Filter Issue...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/incubator-carbondata/pull/616
Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/993/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata issue #616: [CARBONDATA-708] Fixed Between Filter Issue...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/incubator-carbondata/pull/616
Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/982/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata pull request #616: [CARBONDATA-708] Fixed Between Filte...
Posted by bhavya411 <gi...@git.apache.org>.
Github user bhavya411 commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/616#discussion_r105888634
--- Diff: integration/spark2/src/main/scala/org/apache/carbondata/spark/CarbonFilters.scala ---
@@ -110,8 +110,16 @@ object CarbonFilters {
}
def getCarbonLiteralExpression(name: String, value: Any): CarbonExpression = {
- new CarbonLiteralExpression(value,
- CarbonScalaUtil.convertSparkToCarbonDataType(dataTypeOf(name)))
+ val dataTypeOfAttribute = CarbonScalaUtil.convertSparkToCarbonDataType(dataTypeOf(name))
+ val dataType = if (Option(value).isDefined
+ && dataTypeOfAttribute == DataType.STRING
+ && value.isInstanceOf[Double]) {
--- End diff --
In the scenarios where we have stored the numbers as String (and have included it as a Dimension) and if we are trying to do operations like >= or <= or between it is not working correctly
and it gives some random results as it is comparing a String with a Double. So for those cases this fix will work.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata issue #616: [CARBONDATA-708] Fixed Between Filter Issue...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/incubator-carbondata/pull/616
Please rebase the code.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata issue #616: [CARBONDATA-708] Fixed Between Filter Issue...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/incubator-carbondata/pull/616
Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1015/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---