You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kvrocks.apache.org by GitBox <gi...@apache.org> on 2022/11/01 13:13:43 UTC
[GitHub] [incubator-kvrocks] manchurio opened a new pull request, #1060: Fix log-dir and backup-dir appear at the same time.
manchurio opened a new pull request, #1060:
URL: https://github.com/apache/incubator-kvrocks/pull/1060
This closes #1059
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] manchurio commented on pull request #1060: Fix log-dir and backup-dir appear at the same time.
Posted by GitBox <gi...@apache.org>.
manchurio commented on PR #1060:
URL: https://github.com/apache/incubator-kvrocks/pull/1060#issuecomment-1298521434
> @manchurio Thanks for your report and PR, I think the root cause is using before the glog dir was specified in config::Load, so it will send logs to the default dir(/tmp), so this fix is not exactly correct.
@git-hulk Thanks for the explanation, do you have any suggestion?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] git-hulk commented on pull request #1060: Fix log-dir and backup-dir appear at the same time.
Posted by GitBox <gi...@apache.org>.
git-hulk commented on PR #1060:
URL: https://github.com/apache/incubator-kvrocks/pull/1060#issuecomment-1304504240
@manchurio #1061 has fixed this bug and will close this PR, feel free to reopen it if need.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] git-hulk commented on pull request #1060: Fix log-dir and backup-dir appear at the same time.
Posted by GitBox <gi...@apache.org>.
git-hulk commented on PR #1060:
URL: https://github.com/apache/incubator-kvrocks/pull/1060#issuecomment-1298514946
@manchurio Thanks for your report and PR, I think the root cause is using before the glog dir was specified in config::Load, so it will send logs to the default dir(/tmp), so this fixes is not exactly correct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] manchurio commented on pull request #1060: Fix log-dir and backup-dir appear at the same time.
Posted by GitBox <gi...@apache.org>.
manchurio commented on PR #1060:
URL: https://github.com/apache/incubator-kvrocks/pull/1060#issuecomment-1298538346
But that doesn't stop others from doing it again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] PragmaTwice commented on pull request #1060: Fix log-dir and backup-dir appear at the same time.
Posted by GitBox <gi...@apache.org>.
PragmaTwice commented on PR #1060:
URL: https://github.com/apache/incubator-kvrocks/pull/1060#issuecomment-1298667245
We do not need to log the first assignment of backup dir:
```diff
--- if (!previous_backup.empty()) {
+++ if (srv && !previous_backup.empty()) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] mapleFU commented on pull request #1060: Fix log-dir and backup-dir appear at the same time.
Posted by GitBox <gi...@apache.org>.
mapleFU commented on PR #1060:
URL: https://github.com/apache/incubator-kvrocks/pull/1060#issuecomment-1298634175
> I think we can simply remove the logging when the previous backup dir was changed. So that we won't use glog before `initGoogleLog` was called.
@git-hulk It's ok, but changing the backup dir may cause some problems, maybe we can logging in `set` command?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] git-hulk commented on pull request #1060: Fix log-dir and backup-dir appear at the same time.
Posted by GitBox <gi...@apache.org>.
git-hulk commented on PR #1060:
URL: https://github.com/apache/incubator-kvrocks/pull/1060#issuecomment-1298549568
> backup dir was changed. So that we won't use glog before `initGoogleLog` was called. cc @mapleFU
> But that doesn't stop others from doing it again.
We avoid this by moving `google::InitGoogleLogging` into initGoogleLog(), so that all logs will be sent to stderr.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] git-hulk commented on pull request #1060: Fix log-dir and backup-dir appear at the same time.
Posted by GitBox <gi...@apache.org>.
git-hulk commented on PR #1060:
URL: https://github.com/apache/incubator-kvrocks/pull/1060#issuecomment-1298526767
@manchurio I think we can simply remove the logging when the previous backup dir was changed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] git-hulk closed pull request #1060: Fix log-dir and backup-dir appear at the same time.
Posted by GitBox <gi...@apache.org>.
git-hulk closed pull request #1060: Fix log-dir and backup-dir appear at the same time.
URL: https://github.com/apache/incubator-kvrocks/pull/1060
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org