You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by "David Mollitor (Jira)" <ji...@apache.org> on 2019/12/04 20:16:00 UTC

[jira] [Created] (HBASE-23368) Optimize Debug Logging of ClientZKSyncer

David Mollitor created HBASE-23368:
--------------------------------------

             Summary: Optimize Debug Logging of ClientZKSyncer
                 Key: HBASE-23368
                 URL: https://issues.apache.org/jira/browse/HBASE-23368
             Project: HBase
          Issue Type: Improvement
            Reporter: David Mollitor
            Assignee: David Mollitor


In particular, this caught my eye:

{code:java|title=ClientZKSyncer.java}
    // set meta znodes for client ZK
    Collection<String> nodes = getNodesToWatch();
    LOG.debug("Znodes to watch: " + nodes);
{code}

There are no guards around this debug statement, so the entire list of nodes is always turned into a string and passed to the {{debug}} method,... and then promptly discarded if debug is not enabled.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)