You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@royale.apache.org by ha...@apache.org on 2022/01/04 08:38:38 UTC
[royale-asjs] branch develop updated: 99% sure this needs to change
This is an automated email from the ASF dual-hosted git repository.
harbs pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/royale-asjs.git
The following commit(s) were added to refs/heads/develop by this push:
new 21a322c 99% sure this needs to change
21a322c is described below
commit 21a322cb90bf8a7e55154379b53a12e13faff9f7
Author: Harbs <ha...@in-tools.com>
AuthorDate: Tue Jan 4 10:38:04 2022 +0200
99% sure this needs to change
---
.../Basic/src/main/royale/org/apache/royale/html/MXMLBeadView.as | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/frameworks/projects/Basic/src/main/royale/org/apache/royale/html/MXMLBeadView.as b/frameworks/projects/Basic/src/main/royale/org/apache/royale/html/MXMLBeadView.as
index 8be04f3..86652f7 100644
--- a/frameworks/projects/Basic/src/main/royale/org/apache/royale/html/MXMLBeadView.as
+++ b/frameworks/projects/Basic/src/main/royale/org/apache/royale/html/MXMLBeadView.as
@@ -95,7 +95,7 @@ package org.apache.royale.html
*/
public function get model():Object
{
- return _strand["model"];
+ return _strand.model;
}
/**
Re: [royale-asjs] branch develop updated: 99% sure this needs to change
Posted by Harbs <ha...@gmail.com>.
It did. I had the wrong project open and I’m feeling under the weather today... PEBCAK… ;-)
> On Jan 4, 2022, at 7:08 PM, Alex Harui <ah...@adobe.com.INVALID> wrote:
>
> That didn’t generate a warning? Or did you add 'model' to IStrand?
>
> On 1/4/22, 12:39 AM, "harbs@apache.org" <ha...@apache.org> wrote:
>
> This is an automated email from the ASF dual-hosted git repository.
>
> harbs pushed a commit to branch develop
> in repository https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitbox.apache.org%2Frepos%2Fasf%2Froyale-asjs.git&data=04%7C01%7Caharui%40adobe.com%7C6e1a1ea3154c43df1e6008d9cf5d9cae%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637768823802656035%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=5T06ngEt872usaPZQzw9s1qa73WQNGiZKk7w80L7okc%3D&reserved=0
>
>
> The following commit(s) were added to refs/heads/develop by this push:
> new 21a322c 99% sure this needs to change
> 21a322c is described below
>
> commit 21a322cb90bf8a7e55154379b53a12e13faff9f7
> Author: Harbs <ha...@in-tools.com>
> AuthorDate: Tue Jan 4 10:38:04 2022 +0200
>
> 99% sure this needs to change
> ---
> .../Basic/src/main/royale/org/apache/royale/html/MXMLBeadView.as | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/frameworks/projects/Basic/src/main/royale/org/apache/royale/html/MXMLBeadView.as b/frameworks/projects/Basic/src/main/royale/org/apache/royale/html/MXMLBeadView.as
> index 8be04f3..86652f7 100644
> --- a/frameworks/projects/Basic/src/main/royale/org/apache/royale/html/MXMLBeadView.as
> +++ b/frameworks/projects/Basic/src/main/royale/org/apache/royale/html/MXMLBeadView.as
> @@ -95,7 +95,7 @@ package org.apache.royale.html
> */
> public function get model():Object
> {
> - return _strand["model"];
> + return _strand.model;
> }
>
> /**
>
Re: [royale-asjs] branch develop updated: 99% sure this needs to change
Posted by Harbs <ha...@gmail.com>.
Yeah. I fixed it in a later commit. It needed to be cast as IStrandWithModel.
Bracket access can break minification. That’s why I changed it.
> On Jan 4, 2022, at 7:08 PM, Alex Harui <ah...@adobe.com.INVALID> wrote:
>
> That didn’t generate a warning? Or did you add 'model' to IStrand?
>
> On 1/4/22, 12:39 AM, "harbs@apache.org" <ha...@apache.org> wrote:
>
> This is an automated email from the ASF dual-hosted git repository.
>
> harbs pushed a commit to branch develop
> in repository https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitbox.apache.org%2Frepos%2Fasf%2Froyale-asjs.git&data=04%7C01%7Caharui%40adobe.com%7C6e1a1ea3154c43df1e6008d9cf5d9cae%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637768823802656035%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=5T06ngEt872usaPZQzw9s1qa73WQNGiZKk7w80L7okc%3D&reserved=0
>
>
> The following commit(s) were added to refs/heads/develop by this push:
> new 21a322c 99% sure this needs to change
> 21a322c is described below
>
> commit 21a322cb90bf8a7e55154379b53a12e13faff9f7
> Author: Harbs <ha...@in-tools.com>
> AuthorDate: Tue Jan 4 10:38:04 2022 +0200
>
> 99% sure this needs to change
> ---
> .../Basic/src/main/royale/org/apache/royale/html/MXMLBeadView.as | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/frameworks/projects/Basic/src/main/royale/org/apache/royale/html/MXMLBeadView.as b/frameworks/projects/Basic/src/main/royale/org/apache/royale/html/MXMLBeadView.as
> index 8be04f3..86652f7 100644
> --- a/frameworks/projects/Basic/src/main/royale/org/apache/royale/html/MXMLBeadView.as
> +++ b/frameworks/projects/Basic/src/main/royale/org/apache/royale/html/MXMLBeadView.as
> @@ -95,7 +95,7 @@ package org.apache.royale.html
> */
> public function get model():Object
> {
> - return _strand["model"];
> + return _strand.model;
> }
>
> /**
>
Re: [royale-asjs] branch develop updated: 99% sure this needs to change
Posted by Alex Harui <ah...@adobe.com.INVALID>.
That didn’t generate a warning? Or did you add 'model' to IStrand?
On 1/4/22, 12:39 AM, "harbs@apache.org" <ha...@apache.org> wrote:
This is an automated email from the ASF dual-hosted git repository.
harbs pushed a commit to branch develop
in repository https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitbox.apache.org%2Frepos%2Fasf%2Froyale-asjs.git&data=04%7C01%7Caharui%40adobe.com%7C6e1a1ea3154c43df1e6008d9cf5d9cae%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637768823802656035%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=5T06ngEt872usaPZQzw9s1qa73WQNGiZKk7w80L7okc%3D&reserved=0
The following commit(s) were added to refs/heads/develop by this push:
new 21a322c 99% sure this needs to change
21a322c is described below
commit 21a322cb90bf8a7e55154379b53a12e13faff9f7
Author: Harbs <ha...@in-tools.com>
AuthorDate: Tue Jan 4 10:38:04 2022 +0200
99% sure this needs to change
---
.../Basic/src/main/royale/org/apache/royale/html/MXMLBeadView.as | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/frameworks/projects/Basic/src/main/royale/org/apache/royale/html/MXMLBeadView.as b/frameworks/projects/Basic/src/main/royale/org/apache/royale/html/MXMLBeadView.as
index 8be04f3..86652f7 100644
--- a/frameworks/projects/Basic/src/main/royale/org/apache/royale/html/MXMLBeadView.as
+++ b/frameworks/projects/Basic/src/main/royale/org/apache/royale/html/MXMLBeadView.as
@@ -95,7 +95,7 @@ package org.apache.royale.html
*/
public function get model():Object
{
- return _strand["model"];
+ return _strand.model;
}
/**