You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Jarek Cecho <ja...@apache.org> on 2015/03/06 19:22:12 UTC
Review Request 31803: SQOOP-2157 Sqoop2: Kite: Add simple integration
test for TO direction
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31803/
-----------------------------------------------------------
Review request for Sqoop.
Bugs: SQOOP-2157
https://issues.apache.org/jira/browse/SQOOP-2157
Repository: sqoop-sqoop2
Description
-------
Added simple integration test for Kite connector.
Diffs
-----
connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/KiteToInitializer.java a9cff77
test/src/test/java/org/apache/sqoop/integration/connector/kite/FromRDBMSToKiteTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/31803/diff/
Testing
-------
The test passes.
Thanks,
Jarek Cecho
Re: Review Request 31803: SQOOP-2157 Sqoop2: Kite: Add simple
integration test for TO direction
Posted by Abraham Elmahrek <ab...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31803/#review76136
-----------------------------------------------------------
Ship it!
Ship It!
- Abraham Elmahrek
On March 11, 2015, 9:47 p.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31803/
> -----------------------------------------------------------
>
> (Updated March 11, 2015, 9:47 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-2157
> https://issues.apache.org/jira/browse/SQOOP-2157
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> Added simple integration test for Kite connector.
>
>
> Diffs
> -----
>
> connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/KiteToInitializer.java a9cff77
> test/src/test/java/org/apache/sqoop/integration/connector/kite/FromRDBMSToKiteTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/31803/diff/
>
>
> Testing
> -------
>
> The test passes.
>
>
> Thanks,
>
> Jarek Cecho
>
>
Re: Review Request 31803: SQOOP-2157 Sqoop2: Kite: Add simple
integration test for TO direction
Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31803/
-----------------------------------------------------------
(Updated March 19, 2015, 2:53 a.m.)
Review request for Sqoop.
Bugs: SQOOP-2157
https://issues.apache.org/jira/browse/SQOOP-2157
Repository: sqoop-sqoop2
Description
-------
Added simple integration test for Kite connector.
Diffs (updated)
-----
connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/KiteToInitializer.java a9cff77
test/src/test/java/org/apache/sqoop/integration/connector/kite/FromRDBMSToKiteTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/31803/diff/
Testing
-------
The test passes.
Thanks,
Jarek Cecho
Re: Review Request 31803: SQOOP-2157 Sqoop2: Kite: Add simple
integration test for TO direction
Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31803/
-----------------------------------------------------------
(Updated March 11, 2015, 9:47 p.m.)
Review request for Sqoop.
Changes
-------
Incorporated Ryan's feedback.
Bugs: SQOOP-2157
https://issues.apache.org/jira/browse/SQOOP-2157
Repository: sqoop-sqoop2
Description
-------
Added simple integration test for Kite connector.
Diffs (updated)
-----
connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/KiteToInitializer.java a9cff77
test/src/test/java/org/apache/sqoop/integration/connector/kite/FromRDBMSToKiteTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/31803/diff/
Testing
-------
The test passes.
Thanks,
Jarek Cecho
Re: Review Request 31803: SQOOP-2157 Sqoop2: Kite: Add simple
integration test for TO direction
Posted by Qian Xu <qi...@intel.com>.
> On March 7, 2015, 2:35 a.m., Ryan Blue wrote:
> > test/src/test/java/org/apache/sqoop/integration/connector/kite/FromRDBMSToKiteTest.java, line 80
> > <https://reviews.apache.org/r/31803/diff/1/?file=887442#file887442line80>
> >
> > Kite doesn't allow CSV as an output format except using a special property used internally for testing. That's because there are a lot of structures that can't be represented as CSV and Kite doesn't support any hacks to represent the data (i.e., field delimiters).
> >
> > Is this actually writing CSV through Kite? If so, how?
We enable csv as experimential. Any unsupported types will be reprensented as string. If it is a naive idea, we can disable csv support.
- Qian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31803/#review75512
-----------------------------------------------------------
On March 7, 2015, 2:22 a.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31803/
> -----------------------------------------------------------
>
> (Updated March 7, 2015, 2:22 a.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-2157
> https://issues.apache.org/jira/browse/SQOOP-2157
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> Added simple integration test for Kite connector.
>
>
> Diffs
> -----
>
> connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/KiteToInitializer.java a9cff77
> test/src/test/java/org/apache/sqoop/integration/connector/kite/FromRDBMSToKiteTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/31803/diff/
>
>
> Testing
> -------
>
> The test passes.
>
>
> Thanks,
>
> Jarek Cecho
>
>
Re: Review Request 31803: SQOOP-2157 Sqoop2: Kite: Add simple
integration test for TO direction
Posted by Ryan Blue <bl...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31803/#review75512
-----------------------------------------------------------
test/src/test/java/org/apache/sqoop/integration/connector/kite/FromRDBMSToKiteTest.java
<https://reviews.apache.org/r/31803/#comment122642>
I think this could use hdfsClient.getUri().getAuthority() instead of string manipulation.
test/src/test/java/org/apache/sqoop/integration/connector/kite/FromRDBMSToKiteTest.java
<https://reviews.apache.org/r/31803/#comment122645>
Kite doesn't allow CSV as an output format except using a special property used internally for testing. That's because there are a lot of structures that can't be represented as CSV and Kite doesn't support any hacks to represent the data (i.e., field delimiters).
Is this actually writing CSV through Kite? If so, how?
- Ryan Blue
On March 6, 2015, 10:22 a.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31803/
> -----------------------------------------------------------
>
> (Updated March 6, 2015, 10:22 a.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-2157
> https://issues.apache.org/jira/browse/SQOOP-2157
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> Added simple integration test for Kite connector.
>
>
> Diffs
> -----
>
> connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/KiteToInitializer.java a9cff77
> test/src/test/java/org/apache/sqoop/integration/connector/kite/FromRDBMSToKiteTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/31803/diff/
>
>
> Testing
> -------
>
> The test passes.
>
>
> Thanks,
>
> Jarek Cecho
>
>