You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kafka.apache.org by ch...@apache.org on 2024/09/19 16:00:53 UTC

(kafka) branch trunk updated: KAFKA-17555 uncomment all checks of testCommonNameLoggingTrustManagerMixValidAndInvalidCertificates (#17220)

This is an automated email from the ASF dual-hosted git repository.

chia7712 pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/kafka.git


The following commit(s) were added to refs/heads/trunk by this push:
     new e90b2460027 KAFKA-17555 uncomment all checks of testCommonNameLoggingTrustManagerMixValidAndInvalidCertificates (#17220)
e90b2460027 is described below

commit e90b24600270424c4b3184cc67a8f5c43438a47f
Author: xijiu <42...@qq.com>
AuthorDate: Fri Sep 20 00:00:36 2024 +0800

    KAFKA-17555 uncomment all checks of testCommonNameLoggingTrustManagerMixValidAndInvalidCertificates (#17220)
    
    Reviewers: TengYao Chi <ki...@gmail.com>, Chia-Ping Tsai <ch...@gmail.com>
---
 .../ssl/CommonNameLoggingTrustManagerFactoryWrapperTest.java        | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/clients/src/test/java/org/apache/kafka/common/security/ssl/CommonNameLoggingTrustManagerFactoryWrapperTest.java b/clients/src/test/java/org/apache/kafka/common/security/ssl/CommonNameLoggingTrustManagerFactoryWrapperTest.java
index 85ddaf49176..15c488e0060 100644
--- a/clients/src/test/java/org/apache/kafka/common/security/ssl/CommonNameLoggingTrustManagerFactoryWrapperTest.java
+++ b/clients/src/test/java/org/apache/kafka/common/security/ssl/CommonNameLoggingTrustManagerFactoryWrapperTest.java
@@ -469,17 +469,17 @@ public class CommonNameLoggingTrustManagerFactoryWrapperTest {
             CommonNameLoggingTrustManager testTrustManager = new CommonNameLoggingTrustManager(origTrustManager, 2);
 
             // Call with valid certificate
-            //assertDoesNotThrow(() -> testTrustManager.checkClientTrusted(validChainWithoutCa, "RSA"));
+            assertDoesNotThrow(() -> testTrustManager.checkClientTrusted(validChainWithoutCa, "RSA"));
             // Call with invalid certificate
             assertThrows(CertificateException.class,
                     () -> testTrustManager.checkClientTrusted(invalidChainWithoutCa, "RSA"));
             // Call with valid certificate again
-            //assertDoesNotThrow(() -> testTrustManager.checkClientTrusted(validChainWithoutCa, "RSA"));
+            assertDoesNotThrow(() -> testTrustManager.checkClientTrusted(validChainWithoutCa, "RSA"));
             // Call with invalid certificate
             assertThrows(CertificateException.class,
                     () -> testTrustManager.checkClientTrusted(invalidChainWithoutCa, "RSA"));
             // Call with valid certificate again
-            //assertDoesNotThrow(() -> testTrustManager.checkClientTrusted(validChainWithoutCa, "RSA"));
+            assertDoesNotThrow(() -> testTrustManager.checkClientTrusted(validChainWithoutCa, "RSA"));
         }
     }