You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/12/30 06:09:00 UTC
[GitHub] [spark] dcoliversun commented on a change in pull request #34983: [SPARK-37713][K8S] assign namespace to executor configmap
dcoliversun commented on a change in pull request #34983:
URL: https://github.com/apache/spark/pull/34983#discussion_r776580634
##########
File path: resource-managers/kubernetes/core/src/test/scala/org/apache/spark/deploy/k8s/submit/KubernetesClientUtilsSuite.scala
##########
@@ -76,4 +80,26 @@ class KubernetesClientUtilsSuite extends SparkFunSuite with BeforeAndAfter {
"testConf.3" -> "test123456")
assert(output === expectedOutput)
}
+
+ test("verify that configmap built as expected") {
+ val configMapName = "testConfigMapName"
+ val properties = Map(Config.KUBERNETES_NAMESPACE.key -> "default")
Review comment:
OK, I change it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org