[Impala-ASF-CR] IMPALA-15028: Add Helm chart render assertions

["Jason Fehr (Code Review)" <ge...@cloudera.org>]

Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/24368 )

Change subject: IMPALA-15028: Add Helm chart render assertions
......................................................................


Patch Set 50:

(5 comments)

http://gerrit.cloudera.org:8080/#/c/24368/50/bin/jenkins/all-tests.sh
File bin/jenkins/all-tests.sh:

http://gerrit.cloudera.org:8080/#/c/24368/50/bin/jenkins/all-tests.sh@35
PS50, Line 35: : ${HELM_CHART_TEST:=true}
Start with defaulting to "false" so these tests are only run on-demand.


http://gerrit.cloudera.org:8080/#/c/24368/50/bin/jenkins/all-tests.sh@101
PS50, Line 101: if [[ "$HELM_CHART_TEST" == true ]]; then
              :   if ! helm/impala/tests/run-chart-tests.sh; then
              :     RET_CODE=1
              :   fi
              : fi
The code changes in this file would make more sense in bin/run-all-tests.sh.  Is there a reason to keep the changes in this file?


http://gerrit.cloudera.org:8080/#/c/24368/50/helm/impala/README.md
File helm/impala/README.md:

http://gerrit.cloudera.org:8080/#/c/24368/50/helm/impala/README.md@388
PS50, Line 388: ## Automated chart checks
Please add documentation about the required dependencies to run this test (e.g. docker, helm, k8s, etc).


http://gerrit.cloudera.org:8080/#/c/24368/50/helm/impala/tests/assert_chart.py
File helm/impala/tests/assert_chart.py:

http://gerrit.cloudera.org:8080/#/c/24368/50/helm/impala/tests/assert_chart.py@1
PS50, Line 1: #!/usr/bin/env python3
This file must be marked executable (permissions 755).
This line must be: #!/usr/bin/env impala-python3

See tests/run-tests.py for an example.


http://gerrit.cloudera.org:8080/#/c/24368/50/helm/impala/tests/run-chart-tests.sh
File helm/impala/tests/run-chart-tests.sh:

http://gerrit.cloudera.org:8080/#/c/24368/50/helm/impala/tests/run-chart-tests.sh@153
PS50, Line 153: python3 "${SCRIPT_DIR}/assert_chart.py" \
This script should not be executed using the "python3" command.  Instead, assert_chart.py should be set up as executable and it should be executed with only "${SCRIPT_DIR}/assert_chart.py"

See similar test script execution in bin/run-all-tests.sh.



-- 
To view, visit http://gerrit.cloudera.org:8080/24368
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I313be431e81a4b98370e51d298b7b2d35e0aded8
Gerrit-Change-Number: 24368
Gerrit-PatchSet: 50
Gerrit-Owner: Anubhav Jindal <an...@gmail.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Anubhav Jindal <an...@gmail.com>
Gerrit-Reviewer: Gokul Kolady <go...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Comment-Date: Tue, 04 Aug 2026 18:32:44 +0000
Gerrit-HasComments: Yes