You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@horaedb.apache.org by "chunshao90 (via GitHub)" <gi...@apache.org> on 2024/03/01 07:34:49 UTC
[PR] chore: add NOTICE file and ASF header [incubator-horaedb]
chunshao90 opened a new pull request, #1491:
URL: https://github.com/apache/incubator-horaedb/pull/1491
## Rationale
Prepare for releasing v2.0.0 .
## Detailed Changes
* Add NOTICE file.
* Add ASF license header.
## Test Plan
CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@horaedb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@horaedb.apache.org
For additional commands, e-mail: commits-help@horaedb.apache.org
Re: [PR] chore: add NOTICE file and ASF header [incubator-horaedb]
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on code in PR #1491:
URL: https://github.com/apache/incubator-horaedb/pull/1491#discussion_r1509879317
##########
horaemeta/server/service/http/route.go:
##########
@@ -1,15 +1,21 @@
-// Copyright 2015 The Prometheus Authors
-// Licensed under the Apache License, Version 2.0 (the "License");
-// you may not use this file except in compliance with the License.
-// You may obtain a copy of the License at
-//
-// http://www.apache.org/licenses/LICENSE-2.0
-//
-// Unless required by applicable law or agreed to in writing, software
-// distributed under the License is distributed on an "AS IS" BASIS,
-// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-// See the License for the specific language governing permissions and
-// limitations under the License.
+/*
Review Comment:
ditto - Don't change the 3rd source's license header.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@horaedb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@horaedb.apache.org
For additional commands, e-mail: commits-help@horaedb.apache.org
Re: [PR] chore: add NOTICE file and ASF header [incubator-horaedb]
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on code in PR #1491:
URL: https://github.com/apache/incubator-horaedb/pull/1491#discussion_r1509879220
##########
horaemeta/server/coordinator/scheduler/nodepicker/hash/consistent_uniform_test.go:
##########
@@ -21,6 +21,25 @@
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
// THE SOFTWARE.
+/*
Review Comment:
No need for copied 3rd source.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@horaedb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@horaedb.apache.org
For additional commands, e-mail: commits-help@horaedb.apache.org
Re: [PR] chore: add NOTICE file and ASF header [incubator-horaedb]
Posted by "ShiKaiWi (via GitHub)" <gi...@apache.org>.
ShiKaiWi merged PR #1491:
URL: https://github.com/apache/incubator-horaedb/pull/1491
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@horaedb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@horaedb.apache.org
For additional commands, e-mail: commits-help@horaedb.apache.org
Re: [PR] chore: add NOTICE file and ASF header [incubator-horaedb]
Posted by "ShiKaiWi (via GitHub)" <gi...@apache.org>.
ShiKaiWi commented on PR #1491:
URL: https://github.com/apache/incubator-horaedb/pull/1491#issuecomment-1972726308
Why we should exclude these files for license header checking in the horaemeta project:
```
excludes = [
# Derived
"server/service/http/route.go",
"server/coordinator/scheduler/nodepicker/hash/consistent_uniform_test.go",
"server/coordinator/scheduler/nodepicker/hash/consistent_uniform.go",
]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@horaedb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@horaedb.apache.org
For additional commands, e-mail: commits-help@horaedb.apache.org
Re: [PR] chore: add NOTICE file and ASF header [incubator-horaedb]
Posted by "chunshao90 (via GitHub)" <gi...@apache.org>.
chunshao90 commented on code in PR #1491:
URL: https://github.com/apache/incubator-horaedb/pull/1491#discussion_r1510770936
##########
horaemeta/server/service/http/route.go:
##########
@@ -1,15 +1,21 @@
-// Copyright 2015 The Prometheus Authors
-// Licensed under the Apache License, Version 2.0 (the "License");
-// you may not use this file except in compliance with the License.
-// You may obtain a copy of the License at
-//
-// http://www.apache.org/licenses/LICENSE-2.0
-//
-// Unless required by applicable law or agreed to in writing, software
-// distributed under the License is distributed on an "AS IS" BASIS,
-// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-// See the License for the specific language governing permissions and
-// limitations under the License.
+/*
Review Comment:
It's my fault and has been rolled back. We have made some changes to this file. Do we need to add a new license header?
##########
horaemeta/server/coordinator/scheduler/nodepicker/hash/consistent_uniform_test.go:
##########
@@ -21,6 +21,25 @@
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
// THE SOFTWARE.
+/*
Review Comment:
OK
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@horaedb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@horaedb.apache.org
For additional commands, e-mail: commits-help@horaedb.apache.org