You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "amoghrajesh (via GitHub)" <gi...@apache.org> on 2024/11/14 15:28:34 UTC

[I] Add a date formatter for new public API test cases [airflow]

amoghrajesh opened a new issue, #44033:
URL: https://github.com/apache/airflow/issues/44033

   ### Body
   
   As per this comment: https://github.com/apache/airflow/pull/43874#discussion_r1842333308, we need to add a date formatter in our new API test cases. This is because right now, we do something like this: `"data_interval_end": dr.data_interval_end.isoformat().replace("+00:00", "Z")` to account for the move from +00:00 to Z time format.
   
   Adding this new formatter will clean up the tests and make it easier to extend.
   
   ### Committer
   
   - [X] I acknowledge that I am a maintainer/committer of the Apache Airflow project.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Add a date formatter for new public API test cases [airflow]

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk closed issue #44033: Add a date formatter for new public API test cases
URL: https://github.com/apache/airflow/issues/44033


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Add a date formatter for new public API test cases [airflow]

Posted by "Tomi-1997 (via GitHub)" <gi...@apache.org>.
Tomi-1997 commented on issue #44033:
URL: https://github.com/apache/airflow/issues/44033#issuecomment-3997907175

   Could this be solved by using the existing functions from [test_utils\format_datetime.py?](https://github.com/apache/airflow/blob/main/devel-common/src/tests_common/test_utils/format_datetime.py)
   (which seems to already used in some test cases)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Add a date formatter for new public API test cases [airflow]

Posted by "amoghrajesh (via GitHub)" <gi...@apache.org>.
amoghrajesh commented on issue #44033:
URL: https://github.com/apache/airflow/issues/44033#issuecomment-2480330510

   Feel free. Assigning to you.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Add a date formatter for new public API test cases [airflow]

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on issue #44033:
URL: https://github.com/apache/airflow/issues/44033#issuecomment-3986474358

   @iprithv We are unassigning you from this issue as part of our updated [assignment policy](https://github.com/apache/airflow/blob/main/contributing-docs/04_how_to_contribute.rst#contribute-code-changes).
   
   This is not meant to discourage your contribution — quite the opposite! You are still very welcome to work on this issue and submit a PR for it. Simply comment that you are working on it and open a PR when ready.
   
   We found that formal assignments were not working well, as they often prevented others from contributing when the assignee was not actively working on the issue.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Add a date formatter for new public API test cases [airflow]

Posted by "iprithv (via GitHub)" <gi...@apache.org>.
iprithv commented on issue #44033:
URL: https://github.com/apache/airflow/issues/44033#issuecomment-2479824786

   I would like to work on this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org