You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/09/28 09:15:30 UTC

[GitHub] [dubbo-go-pixiu] baerwang opened a new pull request #260: fix：POST request body is missing

baerwang opened a new pull request #260:
URL: https://github.com/apache/dubbo-go-pixiu/pull/260


   <!--  Thanks for sending a pull request! 
   -->
   
   **What this PR does**:
   
   **Which issue(s) this PR fixes**:
   <!--
   *Automatically closes linked issue when PR is merged.
   Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
   _If PR is about `failing-tests or flakes`, please post the related issues/tests in a comment and do not use `Fixes`_*
   -->
   Fixes https://github.com/apache/dubbo-go-pixiu/issues/259
   
   **Special notes for your reviewer**:
   
   **Does this PR introduce a user-facing change?**:
   <!--
   If no, just write "NONE" in the release-note block below.
   If yes, a release note is required:
   Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required".
   -->
   ```release-note
   NONE
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-pixiu] baerwang commented on a change in pull request #260: fix：POST request body is missing

Posted by GitBox <gi...@apache.org>.
baerwang commented on a change in pull request #260:
URL: https://github.com/apache/dubbo-go-pixiu/pull/260#discussion_r717685756



##########
File path: pkg/filter/http/httpproxy/routerfilter.go
##########
@@ -51,15 +51,17 @@ type (
 		cfg *Config
 	}
 	// Config describe the config of Filter
-	Config struct{}
+	Config struct {
+		client *http3.Client

Review comment:
       我想的是把整个http.Client交给用户，http.Clinet 里的其它的配置也许用户需要用呢？




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-pixiu] codecov-commenter commented on pull request #260: fix：POST request body is missing

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #260:
URL: https://github.com/apache/dubbo-go-pixiu/pull/260#issuecomment-929738338


   # [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/260?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#260](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/260?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a2ec2e9) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/32e944a1d93472111c75cb7beb0d5ed30122c5f4?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (32e944a) will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/260/graphs/tree.svg?width=650&height=150&src=pr&token=NM3dY2xLkL&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/260?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@           Coverage Diff            @@
   ##           develop     #260   +/-   ##
   ========================================
     Coverage    39.51%   39.51%           
   ========================================
     Files           50       50           
     Lines         2584     2584           
   ========================================
     Hits          1021     1021           
     Misses        1452     1452           
     Partials       111      111           
   ```
   
   
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/260?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/260?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [32e944a...a2ec2e9](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/260?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-pixiu] ztelur merged pull request #260: fix：POST request body is missing

Posted by GitBox <gi...@apache.org>.
ztelur merged pull request #260:
URL: https://github.com/apache/dubbo-go-pixiu/pull/260


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-pixiu] ztelur commented on pull request #260: fix：POST request body is missing

Posted by GitBox <gi...@apache.org>.
ztelur commented on pull request #260:
URL: https://github.com/apache/dubbo-go-pixiu/pull/260#issuecomment-929187375


   ```
   Filter struct {
     cfg *Config
     client *http3.Client
   }
   ```
   is this way better ? leave config empty for adding more  config property for httpclient further


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-pixiu] mark4z commented on pull request #260: fix：POST request body is missing

Posted by GitBox <gi...@apache.org>.
mark4z commented on pull request #260:
URL: https://github.com/apache/dubbo-go-pixiu/pull/260#issuecomment-929735170


   这样不太好哦


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-pixiu] codecov-commenter edited a comment on pull request #260: fix：POST request body is missing

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #260:
URL: https://github.com/apache/dubbo-go-pixiu/pull/260#issuecomment-929738338


   # [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/260?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#260](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/260?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d374a53) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/6a282f047c0cedbd46d2d58f779efb68fabc4343?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6a282f0) will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/260/graphs/tree.svg?width=650&height=150&src=pr&token=NM3dY2xLkL&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/260?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@           Coverage Diff            @@
   ##           develop     #260   +/-   ##
   ========================================
     Coverage    39.75%   39.75%           
   ========================================
     Files           50       50           
     Lines         2568     2568           
   ========================================
     Hits          1021     1021           
     Misses        1436     1436           
     Partials       111      111           
   ```
   
   
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/260?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/260?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6a282f0...d374a53](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/260?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-pixiu] mark4z removed a comment on pull request #260: fix：POST request body is missing

Posted by GitBox <gi...@apache.org>.
mark4z removed a comment on pull request #260:
URL: https://github.com/apache/dubbo-go-pixiu/pull/260#issuecomment-929735170


   这样不太好哦


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-pixiu] mark4z removed a comment on pull request #260: fix：POST request body is missing

Posted by GitBox <gi...@apache.org>.
mark4z removed a comment on pull request #260:
URL: https://github.com/apache/dubbo-go-pixiu/pull/260#issuecomment-929735170


   这样不太好哦


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-pixiu] codecov-commenter commented on pull request #260: fix：POST request body is missing

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #260:
URL: https://github.com/apache/dubbo-go-pixiu/pull/260#issuecomment-929738338


   # [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/260?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#260](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/260?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a2ec2e9) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/32e944a1d93472111c75cb7beb0d5ed30122c5f4?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (32e944a) will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/260/graphs/tree.svg?width=650&height=150&src=pr&token=NM3dY2xLkL&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/260?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@           Coverage Diff            @@
   ##           develop     #260   +/-   ##
   ========================================
     Coverage    39.51%   39.51%           
   ========================================
     Files           50       50           
     Lines         2584     2584           
   ========================================
     Hits          1021     1021           
     Misses        1452     1452           
     Partials       111      111           
   ```
   
   
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/260?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/260?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [32e944a...a2ec2e9](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/260?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-pixiu] codecov-commenter edited a comment on pull request #260: fix：POST request body is missing

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #260:
URL: https://github.com/apache/dubbo-go-pixiu/pull/260#issuecomment-929738338


   # [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/260?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#260](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/260?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9a605e1) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/32e944a1d93472111c75cb7beb0d5ed30122c5f4?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (32e944a) will **increase** coverage by `0.24%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/260/graphs/tree.svg?width=650&height=150&src=pr&token=NM3dY2xLkL&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/260?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff             @@
   ##           develop     #260      +/-   ##
   ===========================================
   + Coverage    39.51%   39.75%   +0.24%     
   ===========================================
     Files           50       50              
     Lines         2584     2568      -16     
   ===========================================
     Hits          1021     1021              
   + Misses        1452     1436      -16     
     Partials       111      111              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/260?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [pkg/client/http/http.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/260/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NsaWVudC9odHRwL2h0dHAuZ28=) | `42.16% <0.00%> (-1.05%)` | :arrow_down: |
   | [pkg/context/http/util.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/260/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbnRleHQvaHR0cC91dGlsLmdv) | `0.00% <0.00%> (ø)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/260?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/260?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [32e944a...9a605e1](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/260?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-pixiu] baerwang commented on pull request #260: fix：POST request body is missing

Posted by GitBox <gi...@apache.org>.
baerwang commented on pull request #260:
URL: https://github.com/apache/dubbo-go-pixiu/pull/260#issuecomment-929333346


   > ```
   > Filter struct {
   >   cfg *Config
   >   client *http3.Client
   > }
   > ```
   > 
   > 这种方式更好吗？将配置留空以进一步为 httpclient 添加更多配置属性
   
   我觉得可以，另外这种还可以保证代码的统一规范


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-pixiu] baerwang commented on a change in pull request #260: fix：POST request body is missing

Posted by GitBox <gi...@apache.org>.
baerwang commented on a change in pull request #260:
URL: https://github.com/apache/dubbo-go-pixiu/pull/260#discussion_r717685756



##########
File path: pkg/filter/http/httpproxy/routerfilter.go
##########
@@ -51,15 +51,17 @@ type (
 		cfg *Config
 	}
 	// Config describe the config of Filter
-	Config struct{}
+	Config struct {
+		client *http3.Client

Review comment:
       我想的是把整个http.Client交给用户，http.Clinet 里的其它的配置也许用户需要用呢？




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-pixiu] dk-lockdown commented on a change in pull request #260: fix：POST request body is missing

Posted by GitBox <gi...@apache.org>.
dk-lockdown commented on a change in pull request #260:
URL: https://github.com/apache/dubbo-go-pixiu/pull/260#discussion_r718057760



##########
File path: pkg/filter/http/httpproxy/routerfilter.go
##########
@@ -51,15 +51,17 @@ type (
 		cfg *Config
 	}
 	// Config describe the config of Filter
-	Config struct{}
+	Config struct {
+		client *http3.Client

Review comment:
       transport 是一个 interface，直接反序列化 client 怎么样知道 transport 反序列化到哪个对象上呢。




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-pixiu] dk-lockdown commented on a change in pull request #260: fix：POST request body is missing

Posted by GitBox <gi...@apache.org>.
dk-lockdown commented on a change in pull request #260:
URL: https://github.com/apache/dubbo-go-pixiu/pull/260#discussion_r717608401



##########
File path: pkg/filter/http/httpproxy/routerfilter.go
##########
@@ -51,15 +51,17 @@ type (
 		cfg *Config
 	}
 	// Config describe the config of Filter
-	Config struct{}
+	Config struct {
+		client *http3.Client

Review comment:
       不应将整个 http.Client 给用户反序列化配置，用户只需要关注 transport 的内容




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-pixiu] baerwang commented on a change in pull request #260: fix：POST request body is missing

Posted by GitBox <gi...@apache.org>.
baerwang commented on a change in pull request #260:
URL: https://github.com/apache/dubbo-go-pixiu/pull/260#discussion_r718102183



##########
File path: pkg/filter/http/httpproxy/routerfilter.go
##########
@@ -51,15 +51,17 @@ type (
 		cfg *Config
 	}
 	// Config describe the config of Filter
-	Config struct{}
+	Config struct {
+		client *http3.Client

Review comment:
       我不太明白你说的反序列化client场景的所在的意义，如果以为有这个必要的话，我可以重新提交pr

##########
File path: pkg/filter/http/httpproxy/routerfilter.go
##########
@@ -51,15 +51,17 @@ type (
 		cfg *Config
 	}
 	// Config describe the config of Filter
-	Config struct{}
+	Config struct {
+		client *http3.Client

Review comment:
       好的，那我把transport放到filter结构体下，保证当前该代码的统一风格，有问题嘛




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-pixiu] baerwang commented on a change in pull request #260: fix：POST request body is missing

Posted by GitBox <gi...@apache.org>.
baerwang commented on a change in pull request #260:
URL: https://github.com/apache/dubbo-go-pixiu/pull/260#discussion_r718127382



##########
File path: pkg/filter/http/httpproxy/routerfilter.go
##########
@@ -51,15 +51,17 @@ type (
 		cfg *Config
 	}
 	// Config describe the config of Filter
-	Config struct{}
+	Config struct {
+		client *http3.Client

Review comment:
       好的，那我把transport放到filter结构体下，保证当前该代码的统一风格，有问题嘛




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-pixiu] dk-lockdown commented on a change in pull request #260: fix：POST request body is missing

Posted by GitBox <gi...@apache.org>.
dk-lockdown commented on a change in pull request #260:
URL: https://github.com/apache/dubbo-go-pixiu/pull/260#discussion_r717608401



##########
File path: pkg/filter/http/httpproxy/routerfilter.go
##########
@@ -51,15 +51,17 @@ type (
 		cfg *Config
 	}
 	// Config describe the config of Filter
-	Config struct{}
+	Config struct {
+		client *http3.Client

Review comment:
       不应将整个 http.Client 给用户反序列化配置，用户只需要关注 transport 的内容




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-pixiu] mark4z commented on pull request #260: fix：POST request body is missing

Posted by GitBox <gi...@apache.org>.
mark4z commented on pull request #260:
URL: https://github.com/apache/dubbo-go-pixiu/pull/260#issuecomment-929735170


   这样不太好哦


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-pixiu] dk-lockdown commented on a change in pull request #260: fix：POST request body is missing

Posted by GitBox <gi...@apache.org>.
dk-lockdown commented on a change in pull request #260:
URL: https://github.com/apache/dubbo-go-pixiu/pull/260#discussion_r718151672



##########
File path: pkg/filter/http/httpproxy/routerfilter.go
##########
@@ -51,15 +51,17 @@ type (
 		cfg *Config
 	}
 	// Config describe the config of Filter
-	Config struct{}
+	Config struct {
+		client *http3.Client

Review comment:
       这样应该没问题




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-pixiu] baerwang commented on a change in pull request #260: fix：POST request body is missing

Posted by GitBox <gi...@apache.org>.
baerwang commented on a change in pull request #260:
URL: https://github.com/apache/dubbo-go-pixiu/pull/260#discussion_r718102183



##########
File path: pkg/filter/http/httpproxy/routerfilter.go
##########
@@ -51,15 +51,17 @@ type (
 		cfg *Config
 	}
 	// Config describe the config of Filter
-	Config struct{}
+	Config struct {
+		client *http3.Client

Review comment:
       我不太明白你说的反序列化client场景的所在的意义，如果以为有这个必要的话，我可以重新提交pr




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-pixiu] ztelur commented on pull request #260: fix：POST request body is missing

Posted by GitBox <gi...@apache.org>.
ztelur commented on pull request #260:
URL: https://github.com/apache/dubbo-go-pixiu/pull/260#issuecomment-929187375


   ```
   Filter struct {
     cfg *Config
     client *http3.Client
   }
   ```
   is this way better ? leave config empty for adding more  config property for httpclient further


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-pixiu] baerwang commented on pull request #260: fix：POST request body is missing

Posted by GitBox <gi...@apache.org>.
baerwang commented on pull request #260:
URL: https://github.com/apache/dubbo-go-pixiu/pull/260#issuecomment-929333346


   > ```
   > Filter struct {
   >   cfg *Config
   >   client *http3.Client
   > }
   > ```
   > 
   > 这种方式更好吗？将配置留空以进一步为 httpclient 添加更多配置属性
   
   我觉得可以，另外这种还可以保证代码的统一规范


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-pixiu] dk-lockdown commented on a change in pull request #260: fix：POST request body is missing

Posted by GitBox <gi...@apache.org>.
dk-lockdown commented on a change in pull request #260:
URL: https://github.com/apache/dubbo-go-pixiu/pull/260#discussion_r718057760



##########
File path: pkg/filter/http/httpproxy/routerfilter.go
##########
@@ -51,15 +51,17 @@ type (
 		cfg *Config
 	}
 	// Config describe the config of Filter
-	Config struct{}
+	Config struct {
+		client *http3.Client

Review comment:
       transport 是一个 interface，直接反序列化 client 怎么样知道 transport 反序列化到哪个对象上呢。

##########
File path: pkg/filter/http/httpproxy/routerfilter.go
##########
@@ -51,15 +51,17 @@ type (
 		cfg *Config
 	}
 	// Config describe the config of Filter
-	Config struct{}
+	Config struct {
+		client *http3.Client

Review comment:
       ```
   func (fm *FilterManager) Apply(name string, conf map[string]interface{}) (HttpFilter, error) {
   	plugin, err := GetHttpFilterPlugin(name)
   	if err != nil {
   		return nil, errors.New("filter not found")
   	}
   
   	filter, err := plugin.CreateFilter()
   
   	if err != nil {
   		return nil, errors.New("plugin create filter error")
   	}
   
   	factoryConf := filter.Config()
           //filter 的 config 是通过 yaml 反序列化去初始化的。
   	if err := yaml.ParseConfig(factoryConf, conf); err != nil {
   		return nil, errors.Wrap(err, "config error")
   	}
   	err = filter.Apply()
   	if err != nil {
   		return nil, errors.Wrap(err, "create fail")
   	}
   	return filter, nil
   }
   ```
   见上面代码注释

##########
File path: pkg/filter/http/httpproxy/routerfilter.go
##########
@@ -51,15 +51,17 @@ type (
 		cfg *Config
 	}
 	// Config describe the config of Filter
-	Config struct{}
+	Config struct {
+		client *http3.Client

Review comment:
       这样应该没问题




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-pixiu] dk-lockdown commented on a change in pull request #260: fix：POST request body is missing

Posted by GitBox <gi...@apache.org>.
dk-lockdown commented on a change in pull request #260:
URL: https://github.com/apache/dubbo-go-pixiu/pull/260#discussion_r718114676



##########
File path: pkg/filter/http/httpproxy/routerfilter.go
##########
@@ -51,15 +51,17 @@ type (
 		cfg *Config
 	}
 	// Config describe the config of Filter
-	Config struct{}
+	Config struct {
+		client *http3.Client

Review comment:
       ```
   func (fm *FilterManager) Apply(name string, conf map[string]interface{}) (HttpFilter, error) {
   	plugin, err := GetHttpFilterPlugin(name)
   	if err != nil {
   		return nil, errors.New("filter not found")
   	}
   
   	filter, err := plugin.CreateFilter()
   
   	if err != nil {
   		return nil, errors.New("plugin create filter error")
   	}
   
   	factoryConf := filter.Config()
           //filter 的 config 是通过 yaml 反序列化去初始化的。
   	if err := yaml.ParseConfig(factoryConf, conf); err != nil {
   		return nil, errors.Wrap(err, "config error")
   	}
   	err = filter.Apply()
   	if err != nil {
   		return nil, errors.Wrap(err, "create fail")
   	}
   	return filter, nil
   }
   ```
   见上面代码注释




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-pixiu] codecov-commenter edited a comment on pull request #260: fix：POST request body is missing

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #260:
URL: https://github.com/apache/dubbo-go-pixiu/pull/260#issuecomment-929738338


   # [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/260?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#260](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/260?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9a605e1) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/32e944a1d93472111c75cb7beb0d5ed30122c5f4?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (32e944a) will **increase** coverage by `0.24%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/260/graphs/tree.svg?width=650&height=150&src=pr&token=NM3dY2xLkL&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/260?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff             @@
   ##           develop     #260      +/-   ##
   ===========================================
   + Coverage    39.51%   39.75%   +0.24%     
   ===========================================
     Files           50       50              
     Lines         2584     2568      -16     
   ===========================================
     Hits          1021     1021              
   + Misses        1452     1436      -16     
     Partials       111      111              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/260?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [pkg/client/http/http.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/260/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NsaWVudC9odHRwL2h0dHAuZ28=) | `42.16% <0.00%> (-1.05%)` | :arrow_down: |
   | [pkg/context/http/util.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/260/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbnRleHQvaHR0cC91dGlsLmdv) | `0.00% <0.00%> (ø)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/260?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/260?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [32e944a...9a605e1](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/260?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org