You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/08/26 02:37:58 UTC

[GitHub] [arrow] jianxind edited a comment on pull request #8049: ARROW-9851: [C++] Disable AVX512 runtime paths with Valgrind

jianxind edited a comment on pull request #8049:
URL: https://github.com/apache/arrow/pull/8049#issuecomment-680426063


   > OK. Then I think that the environment variable approach is better because we already have `ARROW_USER_SIMD_LEVEL` support (I didn't know!). The following patch will work:
   > 
   > ```diff
   > diff --git a/docker-compose.yml b/docker-compose.yml
   > index 86cffad81..55da4b60b 100644
   > --- a/docker-compose.yml
   > +++ b/docker-compose.yml
   > @@ -199,6 +199,7 @@ services:
   >        ARROW_JEMALLOC: "OFF"
   >        ARROW_S3: "OFF"
   >        ARROW_TEST_MEMCHECK: "ON"
   > +      ARROW_USER_SIMD_LEVEL: "AVX2" # AVX512 not supported by Valgrind (ARROW-9851)
   >        ARROW_USE_LD_GOLD: "ON"
   >        BUILD_WARNING_LEVEL: "PRODUCTION"
   >      volumes: *conda-volumes
   > ```
   
   ARROW_USER_SIMD_LEVEL is a ENV variants, will this change pass AVX2 to ARROW_USER_SIMD_LEVEL env?
   https://github.com/apache/arrow/blob/master/cpp/src/arrow/util/cpu_info.cc#L423


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org