You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "derrickaw (via GitHub)" <gi...@apache.org> on 2026/10/15 16:35:23 UTC
[PR] [yaml] fix documentation and tests for flags [beam]
derrickaw opened a new pull request, #40617:
URL: https://github.com/apache/beam/pull/40617
Fixes #37980 and some minor typos.
<!--
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
- [ ] Replace these instructions with a description of your change and why you have made it.
- [ ] Mention the appropriate issue in your description (for example: `addresses #123` or `fixes #456`).
- [ ] Update `CHANGES.md` with noteworthy changes.
See [CONTRIBUTING.md]() for more details.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [yaml] fix documentation and tests for flags [beam]
Posted by "derrickaw (via GitHub)" <gi...@apache.org>.
derrickaw commented on code in PR #40617:
URL: https://github.com/apache/beam/pull/40617#discussion_r4424214305
##########
sdks/python/apache_beam/yaml/main_test.py:
##########
@@ -172,7 +172,12 @@ def test_jinja_datetime(self):
fin.read().strip(), datetime.datetime.now().strftime("%Y-%m-%d"))
def test_inline_test_specs(self):
- main.run_tests(['--yaml_pipeline', TEST_PIPELINE, '--test'], exit=False)
+ for flag in ['--tests', '--test']:
Review Comment:
1. Originally `--test` was added.
2. Then docs were added stating `--tests` was to be used.
3. Another person added `--tests` and kept the backward compatible `--test`.
4. This PR completes the cycle with improved testing for both flags and update documentation.
5. Yea, not the best sequence of events.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [yaml] fix documentation and tests for flags [beam]
Posted by "derrickaw (via GitHub)" <gi...@apache.org>.
derrickaw commented on code in PR #40617:
URL: https://github.com/apache/beam/pull/40617#discussion_r4424214305
##########
sdks/python/apache_beam/yaml/main_test.py:
##########
@@ -172,7 +172,12 @@ def test_jinja_datetime(self):
fin.read().strip(), datetime.datetime.now().strftime("%Y-%m-%d"))
def test_inline_test_specs(self):
- main.run_tests(['--yaml_pipeline', TEST_PIPELINE, '--test'], exit=False)
+ for flag in ['--tests', '--test']:
Review Comment:
1. Originally `--test` was added.
2. Then docs were added stating `--tests` was to be used.
3. Another person added `--tests` and kept the backward compatible `--test`.
4. This PR completes the cycle with improved testing for both flags and update documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [yaml] fix documentation and tests for flags [beam]
Posted by "derrickaw (via GitHub) via github" <gi...@beam.apache.org>.
derrickaw commented on PR #40617:
URL: https://github.com/apache/beam/pull/40617#issuecomment-6663070377
> Thanks! Sorry for the slow turnaround
No worries. Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [yaml] fix documentation and tests for flags [beam]
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on code in PR #40617:
URL: https://github.com/apache/beam/pull/40617#discussion_r4339865161
##########
sdks/python/apache_beam/yaml/main_test.py:
##########
@@ -172,7 +172,12 @@ def test_jinja_datetime(self):
fin.read().strip(), datetime.datetime.now().strftime("%Y-%m-%d"))
def test_inline_test_specs(self):
- main.run_tests(['--yaml_pipeline', TEST_PIPELINE, '--test'], exit=False)
+ for flag in ['--tests', '--test']:
Review Comment:
Why do we have 2 different ways of doing this? Could you add some context?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [yaml] fix documentation and tests for flags [beam]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #40617:
URL: https://github.com/apache/beam/pull/40617#issuecomment-6197879031
## [Codecov](https://app.codecov.io/gh/apache/beam/pull/40617?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 79.88%. Comparing base ([`76f6e6d`](https://app.codecov.io/gh/apache/beam/commit/76f6e6d7c0c1b2ce582c73d068ad9260cf15c5f3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`74b78c7`](https://app.codecov.io/gh/apache/beam/commit/74b78c7bc04d0bad982ad1c91af1ec01b6ca91f2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 195 commits behind head on master.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #40617 +/- ##
=============================================
+ Coverage 56.16% 79.88% +23.71%
=============================================
Files 1124 488 -636
Lines 178336 82432 -95904
Branches 1489 0 -1489
=============================================
- Hits 100170 65852 -34318
+ Misses 75645 16580 -59065
+ Partials 2521 0 -2521
```
| [Flag](https://app.codecov.io/gh/apache/beam/pull/40617/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [go](https://app.codecov.io/gh/apache/beam/pull/40617/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [java](https://app.codecov.io/gh/apache/beam/pull/40617/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [python](https://app.codecov.io/gh/apache/beam/pull/40617/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `79.88% <ø> (+0.33%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/beam/pull/40617?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [yaml] fix documentation and tests for flags [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #40617:
URL: https://github.com/apache/beam/pull/40617#issuecomment-6198815051
Assigning reviewers:
R: @chamikaramj for label yaml.
Backup reviewer: Abacn (if the main reviewer is unresponsive, you can escalate to them by tagging their username)
Note: If you would like to opt out of this review, comment `assign to next reviewer`.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [yaml] fix documentation and tests for flags [beam]
Posted by "derrickaw (via GitHub)" <gi...@apache.org>.
derrickaw commented on code in PR #40617:
URL: https://github.com/apache/beam/pull/40617#discussion_r4426849903
##########
sdks/python/apache_beam/yaml/main_test.py:
##########
@@ -172,7 +172,12 @@ def test_jinja_datetime(self):
fin.read().strip(), datetime.datetime.now().strftime("%Y-%m-%d"))
def test_inline_test_specs(self):
- main.run_tests(['--yaml_pipeline', TEST_PIPELINE, '--test'], exit=False)
+ for flag in ['--tests', '--test']:
Review Comment:
Ok removed the `--test` change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [yaml] fix documentation and tests for flags [beam]
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on code in PR #40617:
URL: https://github.com/apache/beam/pull/40617#discussion_r4425326758
##########
sdks/python/apache_beam/yaml/main_test.py:
##########
@@ -172,7 +172,12 @@ def test_jinja_datetime(self):
fin.read().strip(), datetime.datetime.now().strftime("%Y-%m-%d"))
def test_inline_test_specs(self):
- main.run_tests(['--yaml_pipeline', TEST_PIPELINE, '--test'], exit=False)
+ for flag in ['--tests', '--test']:
Review Comment:
Ok - I think the alias is fine (it probably would've been better to just update the docs, but that ship has sailed). But instead of alluding to both in our docs, lets just pick one and make sure all of our docs use that. I don't care which one we choose, but I think mentioning both (or switching back and forth) will just confuse users and lead them to wonder which one they should choose.
Keeping the main_test.py change is fine
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [yaml] fix documentation and tests for flags [beam]
Posted by "derrickaw (via GitHub)" <gi...@apache.org>.
derrickaw commented on code in PR #40617:
URL: https://github.com/apache/beam/pull/40617#discussion_r4424214305
##########
sdks/python/apache_beam/yaml/main_test.py:
##########
@@ -172,7 +172,12 @@ def test_jinja_datetime(self):
fin.read().strip(), datetime.datetime.now().strftime("%Y-%m-%d"))
def test_inline_test_specs(self):
- main.run_tests(['--yaml_pipeline', TEST_PIPELINE, '--test'], exit=False)
+ for flag in ['--tests', '--test']:
Review Comment:
1. Originally `--test` was added.
2. Then docs were added stating `--tests` was to be used.
3. Another person added `--tests` and kept the backward compatible `--test`.
4. This PR completes the cycle with improved testing for both flags and update documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [yaml] fix documentation and tests for flags [beam]
Posted by "derrickaw (via GitHub)" <gi...@apache.org>.
derrickaw commented on PR #40617:
URL: https://github.com/apache/beam/pull/40617#issuecomment-6198724480
/gemini review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [yaml] fix documentation and tests for flags [beam]
Posted by "derrickaw (via GitHub) via github" <gi...@beam.apache.org>.
derrickaw merged PR #40617:
URL: https://github.com/apache/beam/pull/40617
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [yaml] fix documentation and tests for flags [beam]
Posted by "chamikaramj (via GitHub)" <gi...@apache.org>.
chamikaramj commented on PR #40617:
URL: https://github.com/apache/beam/pull/40617#issuecomment-6420763523
waiting on author
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [yaml] fix documentation and tests for flags [beam]
Posted by "derrickaw (via GitHub)" <gi...@apache.org>.
derrickaw commented on code in PR #40617:
URL: https://github.com/apache/beam/pull/40617#discussion_r4426849903
##########
sdks/python/apache_beam/yaml/main_test.py:
##########
@@ -172,7 +172,12 @@ def test_jinja_datetime(self):
fin.read().strip(), datetime.datetime.now().strftime("%Y-%m-%d"))
def test_inline_test_specs(self):
- main.run_tests(['--yaml_pipeline', TEST_PIPELINE, '--test'], exit=False)
+ for flag in ['--tests', '--test']:
Review Comment:
Ok removed the `--test` change. Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org