[GitHub] [ozone] ayushtkn commented on a change in pull request #3077: HDDS-6305: Add metrics - number of FSO bucket creates

[GitBox <gi...@apache.org>]

ayushtkn commented on a change in pull request #3077:
URL: https://github.com/apache/ozone/pull/3077#discussion_r805115556



##########
File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/bucket/OMBucketCreateRequest.java
##########
@@ -149,7 +149,9 @@ public OMClientResponse validateAndUpdateCache(OzoneManager ozoneManager,
     } else {
       omBucketInfo = OmBucketInfo.getFromProtobuf(bucketInfo);
     }
-
+    if (omBucketInfo.getBucketLayout().isFileSystemOptimized()) {
+      omMetrics.incNumFSOBucketCreates();
+    }

Review comment:
       There is a ``bucketInfo.getBucketLayout() == null`` in the above if block, if that comes true, your code will fetch a NPE here.
   
   Not very sure if it would be ``null`` in any case or not. It should have defaulted to ``LEGACY`` in case of ``null``, May be added for some upgrade stuff or just for sanity...
   
   You can explore pulling up the check inside the else block, that will skip checking ``isFileOptimised`` when you already know the bucket is of type LEGACY. 
   
   ```
       } else {
         omBucketInfo = OmBucketInfo.getFromProtobuf(bucketInfo);
         if (omBucketInfo.getBucketLayout().isFileSystemOptimized()) {
           omMetrics.incNumFSOBucketCreates();
         }
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org