You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by da...@apache.org on 2018/11/12 11:55:57 UTC
[48/50] [abbrv] lucene-solr:jira/http2: SOLR-12978: In autoscaling
NPE thrown for nodes where value is absent
SOLR-12978: In autoscaling NPE thrown for nodes where value is absent
Project: http://git-wip-us.apache.org/repos/asf/lucene-solr/repo
Commit: http://git-wip-us.apache.org/repos/asf/lucene-solr/commit/cd1e8297
Tree: http://git-wip-us.apache.org/repos/asf/lucene-solr/tree/cd1e8297
Diff: http://git-wip-us.apache.org/repos/asf/lucene-solr/diff/cd1e8297
Branch: refs/heads/jira/http2
Commit: cd1e829732157399f7e38d810a38df3f4c2e0792
Parents: e6e6ad2
Author: Noble Paul <no...@apache.org>
Authored: Mon Nov 12 18:53:16 2018 +1100
Committer: Noble Paul <no...@apache.org>
Committed: Mon Nov 12 18:53:16 2018 +1100
----------------------------------------------------------------------
solr/CHANGES.txt | 2 ++
.../org/apache/solr/client/solrj/cloud/autoscaling/RangeVal.java | 1 +
2 files changed, 3 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/lucene-solr/blob/cd1e8297/solr/CHANGES.txt
----------------------------------------------------------------------
diff --git a/solr/CHANGES.txt b/solr/CHANGES.txt
index 6fca62d..8a0e36b 100644
--- a/solr/CHANGES.txt
+++ b/solr/CHANGES.txt
@@ -290,6 +290,8 @@ used with DVHASH method in json.facet. (Tim Underwood via Mikhail Khludnev)
* SOLR-12977: Autoscaling tries to fetch metrics from dead nodes (noble)
+* SOLR-12978: In autoscaling NPE thrown for nodes where value is absent (noble)
+
Improvements
----------------------
http://git-wip-us.apache.org/repos/asf/lucene-solr/blob/cd1e8297/solr/solrj/src/java/org/apache/solr/client/solrj/cloud/autoscaling/RangeVal.java
----------------------------------------------------------------------
diff --git a/solr/solrj/src/java/org/apache/solr/client/solrj/cloud/autoscaling/RangeVal.java b/solr/solrj/src/java/org/apache/solr/client/solrj/cloud/autoscaling/RangeVal.java
index b9f6b8d..11c5ab3 100644
--- a/solr/solrj/src/java/org/apache/solr/client/solrj/cloud/autoscaling/RangeVal.java
+++ b/solr/solrj/src/java/org/apache/solr/client/solrj/cloud/autoscaling/RangeVal.java
@@ -31,6 +31,7 @@ class RangeVal implements MapWriter {
}
public boolean match(Number testVal) {
+ if (testVal == null) return false;
return Double.compare(testVal.doubleValue(), min.doubleValue()) >= 0 &&
Double.compare(testVal.doubleValue(), max.doubleValue()) <= 0;
}