You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Simone Tripodi <si...@apache.org> on 2012/07/18 22:35:56 UTC
[chain] javadoc tags
Hello,
we discussed already a lot on this for other components, anyway it
would be better discussing it before modifying the code:
* is it OK to drop @author tags? original authors, committers and
contributors are already mentioned in the pom
* @version: actually, there is a mix of $Id$, $Revision$ and $Date$
usage. Is it OK to replace all of them with $Id$ only?
TIA! best,
-Simo
http://people.apache.org/~simonetripodi/
http://simonetripodi.livejournal.com/
http://twitter.com/simonetripodi
http://www.99soft.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [chain] javadoc tags
Posted by Gary Gregory <ga...@gmail.com>.
On Wed, Jul 18, 2012 at 4:46 PM, Simone Tripodi <si...@apache.org>wrote:
> another question: since chain2 breaks all kind of backward
> compatibility with previous version... does it really makes sense
> keeping the @since tag?
>
It's ok to keep them IMO.
Gary
>
> TIA!
>
> -Simo
>
> http://people.apache.org/~simonetripodi/
> http://simonetripodi.livejournal.com/
> http://twitter.com/simonetripodi
> http://www.99soft.org/
>
>
> On Wed, Jul 18, 2012 at 10:35 PM, Simone Tripodi
> <si...@apache.org> wrote:
> > Hello,
> >
> > we discussed already a lot on this for other components, anyway it
> > would be better discussing it before modifying the code:
> >
> > * is it OK to drop @author tags? original authors, committers and
> > contributors are already mentioned in the pom
> >
> > * @version: actually, there is a mix of $Id$, $Revision$ and $Date$
> > usage. Is it OK to replace all of them with $Id$ only?
> >
> > TIA! best,
> > -Simo
> >
> > http://people.apache.org/~simonetripodi/
> > http://simonetripodi.livejournal.com/
> > http://twitter.com/simonetripodi
> > http://www.99soft.org/
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
--
E-Mail: garydgregory@gmail.com | ggregory@apache.org
JUnit in Action, 2nd Ed: <http://goog_1249600977>http://bit.ly/ECvg0
Spring Batch in Action: <http://s.apache.org/HOq>http://bit.ly/bqpbCK
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory
Re: [chain] javadoc tags
Posted by Elijah Zupancic <el...@apache.org>.
Great questions. I'm eager to find out what everyone thinks.
-Elijah
On Wed, Jul 18, 2012 at 1:46 PM, Simone Tripodi
<si...@apache.org> wrote:
> another question: since chain2 breaks all kind of backward
> compatibility with previous version... does it really makes sense
> keeping the @since tag?
>
> TIA!
>
> -Simo
>
> http://people.apache.org/~simonetripodi/
> http://simonetripodi.livejournal.com/
> http://twitter.com/simonetripodi
> http://www.99soft.org/
>
>
> On Wed, Jul 18, 2012 at 10:35 PM, Simone Tripodi
> <si...@apache.org> wrote:
>> Hello,
>>
>> we discussed already a lot on this for other components, anyway it
>> would be better discussing it before modifying the code:
>>
>> * is it OK to drop @author tags? original authors, committers and
>> contributors are already mentioned in the pom
>>
>> * @version: actually, there is a mix of $Id$, $Revision$ and $Date$
>> usage. Is it OK to replace all of them with $Id$ only?
>>
>> TIA! best,
>> -Simo
>>
>> http://people.apache.org/~simonetripodi/
>> http://simonetripodi.livejournal.com/
>> http://twitter.com/simonetripodi
>> http://www.99soft.org/
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [chain] javadoc tags
Posted by Simone Tripodi <si...@apache.org>.
another question: since chain2 breaks all kind of backward
compatibility with previous version... does it really makes sense
keeping the @since tag?
TIA!
-Simo
http://people.apache.org/~simonetripodi/
http://simonetripodi.livejournal.com/
http://twitter.com/simonetripodi
http://www.99soft.org/
On Wed, Jul 18, 2012 at 10:35 PM, Simone Tripodi
<si...@apache.org> wrote:
> Hello,
>
> we discussed already a lot on this for other components, anyway it
> would be better discussing it before modifying the code:
>
> * is it OK to drop @author tags? original authors, committers and
> contributors are already mentioned in the pom
>
> * @version: actually, there is a mix of $Id$, $Revision$ and $Date$
> usage. Is it OK to replace all of them with $Id$ only?
>
> TIA! best,
> -Simo
>
> http://people.apache.org/~simonetripodi/
> http://simonetripodi.livejournal.com/
> http://twitter.com/simonetripodi
> http://www.99soft.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [chain] javadoc tags
Posted by Simone Tripodi <si...@apache.org>.
I uniformed to $Id$ since not only there was a Id/Revision+Date mixed
use, but somewhere the tag was not used at all, and the majority of
replied with a preference of Id
thanks and best,
-Simo
http://people.apache.org/~simonetripodi/
http://simonetripodi.livejournal.com/
http://twitter.com/simonetripodi
http://www.99soft.org/
On Fri, Jul 20, 2012 at 1:28 AM, Gary Gregory <ga...@gmail.com> wrote:
> On Jul 19, 2012, at 15:38, sebb <se...@gmail.com> wrote:
>
>> On 19 July 2012 07:54, Simone Tripodi <si...@apache.org> wrote:
>>> Hi Seb,
>>>
>>>> So long as the $Date$ ones are removed, I don't think it matters
>>>> whether the others use Revision or Id.
>>>
>>> thanks for the feedback! since in the code on /trunk there is a mixed
>>> use of both $Id$ and $Revision$, would it worth have a uniformed way?
>>
>> Why bother? Just replace the ones with $Date$ and leave the rest.
>
> Personally, I like the consistency of having $id throughout.
>
> Gary
>
>>
>>> TIA,
>>> -Simo
>>>
>>> http://people.apache.org/~simonetripodi/
>>> http://simonetripodi.livejournal.com/
>>> http://twitter.com/simonetripodi
>>> http://www.99soft.org/
>>>
>>>
>>> On Thu, Jul 19, 2012 at 1:12 AM, sebb <se...@gmail.com> wrote:
>>>> On 18 July 2012 21:35, Simone Tripodi <si...@apache.org> wrote:
>>>>> Hello,
>>>>>
>>>>> we discussed already a lot on this for other components, anyway it
>>>>> would be better discussing it before modifying the code:
>>>>>
>>>>> * is it OK to drop @author tags? original authors, committers and
>>>>> contributors are already mentioned in the pom
>>>>>
>>>>> * @version: actually, there is a mix of $Id$, $Revision$ and $Date$
>>>>> usage. Is it OK to replace all of them with $Id$ only?
>>>>
>>>
>>>>
>>>>> TIA! best,
>>>>> -Simo
>>>>>
>>>>> http://people.apache.org/~simonetripodi/
>>>>> http://simonetripodi.livejournal.com/
>>>>> http://twitter.com/simonetripodi
>>>>> http://www.99soft.org/
>>>>>
>>>>> ---------------------------------------------------------------------
>>>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>>>> For additional commands, e-mail: dev-help@commons.apache.org
>>>>>
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>>> For additional commands, e-mail: dev-help@commons.apache.org
>>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>> For additional commands, e-mail: dev-help@commons.apache.org
>>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [chain] javadoc tags
Posted by Gary Gregory <ga...@gmail.com>.
On Jul 19, 2012, at 15:38, sebb <se...@gmail.com> wrote:
> On 19 July 2012 07:54, Simone Tripodi <si...@apache.org> wrote:
>> Hi Seb,
>>
>>> So long as the $Date$ ones are removed, I don't think it matters
>>> whether the others use Revision or Id.
>>
>> thanks for the feedback! since in the code on /trunk there is a mixed
>> use of both $Id$ and $Revision$, would it worth have a uniformed way?
>
> Why bother? Just replace the ones with $Date$ and leave the rest.
Personally, I like the consistency of having $id throughout.
Gary
>
>> TIA,
>> -Simo
>>
>> http://people.apache.org/~simonetripodi/
>> http://simonetripodi.livejournal.com/
>> http://twitter.com/simonetripodi
>> http://www.99soft.org/
>>
>>
>> On Thu, Jul 19, 2012 at 1:12 AM, sebb <se...@gmail.com> wrote:
>>> On 18 July 2012 21:35, Simone Tripodi <si...@apache.org> wrote:
>>>> Hello,
>>>>
>>>> we discussed already a lot on this for other components, anyway it
>>>> would be better discussing it before modifying the code:
>>>>
>>>> * is it OK to drop @author tags? original authors, committers and
>>>> contributors are already mentioned in the pom
>>>>
>>>> * @version: actually, there is a mix of $Id$, $Revision$ and $Date$
>>>> usage. Is it OK to replace all of them with $Id$ only?
>>>
>>
>>>
>>>> TIA! best,
>>>> -Simo
>>>>
>>>> http://people.apache.org/~simonetripodi/
>>>> http://simonetripodi.livejournal.com/
>>>> http://twitter.com/simonetripodi
>>>> http://www.99soft.org/
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>>> For additional commands, e-mail: dev-help@commons.apache.org
>>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>> For additional commands, e-mail: dev-help@commons.apache.org
>>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [chain] javadoc tags
Posted by sebb <se...@gmail.com>.
On 19 July 2012 07:54, Simone Tripodi <si...@apache.org> wrote:
> Hi Seb,
>
>> So long as the $Date$ ones are removed, I don't think it matters
>> whether the others use Revision or Id.
>
> thanks for the feedback! since in the code on /trunk there is a mixed
> use of both $Id$ and $Revision$, would it worth have a uniformed way?
Why bother? Just replace the ones with $Date$ and leave the rest.
> TIA,
> -Simo
>
> http://people.apache.org/~simonetripodi/
> http://simonetripodi.livejournal.com/
> http://twitter.com/simonetripodi
> http://www.99soft.org/
>
>
> On Thu, Jul 19, 2012 at 1:12 AM, sebb <se...@gmail.com> wrote:
>> On 18 July 2012 21:35, Simone Tripodi <si...@apache.org> wrote:
>>> Hello,
>>>
>>> we discussed already a lot on this for other components, anyway it
>>> would be better discussing it before modifying the code:
>>>
>>> * is it OK to drop @author tags? original authors, committers and
>>> contributors are already mentioned in the pom
>>>
>>> * @version: actually, there is a mix of $Id$, $Revision$ and $Date$
>>> usage. Is it OK to replace all of them with $Id$ only?
>>
>
>>
>>> TIA! best,
>>> -Simo
>>>
>>> http://people.apache.org/~simonetripodi/
>>> http://simonetripodi.livejournal.com/
>>> http://twitter.com/simonetripodi
>>> http://www.99soft.org/
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>> For additional commands, e-mail: dev-help@commons.apache.org
>>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [chain] javadoc tags
Posted by Simone Tripodi <si...@apache.org>.
Hi Seb,
> So long as the $Date$ ones are removed, I don't think it matters
> whether the others use Revision or Id.
thanks for the feedback! since in the code on /trunk there is a mixed
use of both $Id$ and $Revision$, would it worth have a uniformed way?
TIA,
-Simo
http://people.apache.org/~simonetripodi/
http://simonetripodi.livejournal.com/
http://twitter.com/simonetripodi
http://www.99soft.org/
On Thu, Jul 19, 2012 at 1:12 AM, sebb <se...@gmail.com> wrote:
> On 18 July 2012 21:35, Simone Tripodi <si...@apache.org> wrote:
>> Hello,
>>
>> we discussed already a lot on this for other components, anyway it
>> would be better discussing it before modifying the code:
>>
>> * is it OK to drop @author tags? original authors, committers and
>> contributors are already mentioned in the pom
>>
>> * @version: actually, there is a mix of $Id$, $Revision$ and $Date$
>> usage. Is it OK to replace all of them with $Id$ only?
>
>
>> TIA! best,
>> -Simo
>>
>> http://people.apache.org/~simonetripodi/
>> http://simonetripodi.livejournal.com/
>> http://twitter.com/simonetripodi
>> http://www.99soft.org/
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [chain] javadoc tags
Posted by sebb <se...@gmail.com>.
On 18 July 2012 21:35, Simone Tripodi <si...@apache.org> wrote:
> Hello,
>
> we discussed already a lot on this for other components, anyway it
> would be better discussing it before modifying the code:
>
> * is it OK to drop @author tags? original authors, committers and
> contributors are already mentioned in the pom
>
> * @version: actually, there is a mix of $Id$, $Revision$ and $Date$
> usage. Is it OK to replace all of them with $Id$ only?
So long as the $Date$ ones are removed, I don't think it matters
whether the others use Revision or Id.
> TIA! best,
> -Simo
>
> http://people.apache.org/~simonetripodi/
> http://simonetripodi.livejournal.com/
> http://twitter.com/simonetripodi
> http://www.99soft.org/
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [chain] javadoc tags
Posted by Gary Gregory <ga...@gmail.com>.
On Wed, Jul 18, 2012 at 4:35 PM, Simone Tripodi <si...@apache.org>wrote:
> Hello,
>
> we discussed already a lot on this for other components, anyway it
> would be better discussing it before modifying the code:
>
> * is it OK to drop @author tags? original authors, committers and
> contributors are already mentioned in the pom
>
+1.
>
> * @version: actually, there is a mix of $Id$, $Revision$ and $Date$
> usage. Is it OK to replace all of them with $Id$ only?
>
+1.
Gary
>
> TIA! best,
> -Simo
>
> http://people.apache.org/~simonetripodi/
> http://simonetripodi.livejournal.com/
> http://twitter.com/simonetripodi
> http://www.99soft.org/
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
--
E-Mail: garydgregory@gmail.com | ggregory@apache.org
JUnit in Action, 2nd Ed: <http://goog_1249600977>http://bit.ly/ECvg0
Spring Batch in Action: <http://s.apache.org/HOq>http://bit.ly/bqpbCK
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory