You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kvrocks.apache.org by "SongYuQiu (via GitHub)" <gi...@apache.org> on 2023/03/15 12:00:28 UTC

[GitHub] [incubator-kvrocks-website] SongYuQiu opened a new pull request, #64: Add icons and descriptions for four features

SongYuQiu opened a new pull request, #64:
URL: https://github.com/apache/incubator-kvrocks-website/pull/64

   Tasks in https://github.com/apache/incubator-kvrocks/issues/1257 are completed as follows:
   - [x] Modify the colors of Header and Footer, and update the banner.
   - [ ]  Refactor introduction of the Redis Compatible feature.
     - [ ]  Include a text editor with demo.
     - [ ]  Include a pie chart displaying the proportion of implemented Redis commands.
   - [x]  Add icons and descriptions for four features.
   - [ ]  Add a list of logos.
   - [ ]  Make the homepage mobile-friendly (optional).
   - [ ]  Add some animations (optional).
   
   The second subtask is currently only occupying the page with the corresponding elements in the UI design.
   
   Preview:
   ![截屏2023-03-15 19 43 24](https://user-images.githubusercontent.com/46080479/225302339-c5c1737a-7a04-44bb-95a2-9607c1197c15.png)
   ![截屏2023-03-15 19 43 35](https://user-images.githubusercontent.com/46080479/225302356-828ec833-71c3-45ea-acba-550ed8c7d6ed.png)
   ![截屏2023-03-15 19 43 48](https://user-images.githubusercontent.com/46080479/225302377-190ad5e5-2358-4c21-b8fd-8bb511b2b393.png)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kvrocks-website] PragmaTwice commented on pull request #64: Add icons and descriptions for four features

Posted by "PragmaTwice (via GitHub)" <gi...@apache.org>.
PragmaTwice commented on PR #64:
URL: https://github.com/apache/incubator-kvrocks-website/pull/64#issuecomment-1470104218

   Hi @SongYuQiu , here are some suggestions:
   - for implementing text editors, you can use Monaco (https://microsoft.github.io/monaco-editor/);
   - for charts, I would like to recommend Echarts (also in Apache now);
   - for mobile-friendly, I think we do not require a beautiful / perfect view, but at least it cannot be a mess (e.g. overlapped images and buttons).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kvrocks-website] PragmaTwice commented on pull request #64: Add icons and descriptions for four features

Posted by "PragmaTwice (via GitHub)" <gi...@apache.org>.
PragmaTwice commented on PR #64:
URL: https://github.com/apache/incubator-kvrocks-website/pull/64#issuecomment-1476423371

   Seems we can merge the finished part of the work, then newcomers can have noval visual experience.
   
   Let me cleanup the codebase and remove these unfinished part.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kvrocks-website] PragmaTwice commented on pull request #64: Add icons and descriptions for four features

Posted by "PragmaTwice (via GitHub)" <gi...@apache.org>.
PragmaTwice commented on PR #64:
URL: https://github.com/apache/incubator-kvrocks-website/pull/64#issuecomment-1476448335

   @SongYuQiu You can open another PR to bring further features.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kvrocks-website] PragmaTwice merged pull request #64: Add icons and descriptions for four features

Posted by "PragmaTwice (via GitHub)" <gi...@apache.org>.
PragmaTwice merged PR #64:
URL: https://github.com/apache/incubator-kvrocks-website/pull/64


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kvrocks-website] SongYuQiu commented on pull request #64: Add icons and descriptions for four features

Posted by "SongYuQiu (via GitHub)" <gi...@apache.org>.
SongYuQiu commented on PR #64:
URL: https://github.com/apache/incubator-kvrocks-website/pull/64#issuecomment-1470113244

   > Hi @SongYuQiu , here are some suggestions:
   > 
   > * for implementing text editors, you can use Monaco (https://microsoft.github.io/monaco-editor/);
   > * for charts, I would like to recommend Echarts (also in Apache now);
   > * for mobile-friendly, I think we do not require a beautiful / perfect view, but at least it cannot be a mess (e.g. overlapped text, images and buttons, or other renderring errors).
   
   Ok, after confirming the content of the text editors and the chart, I will modify it accordingly. For mobile-friendly, I'll do that in the next step.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org