You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "dan-s1 (via GitHub)" <gi...@apache.org> on 2025/12/24 14:41:00 UTC
[PR] NIFI-15387 Re-enabled nine out of eleven tests in TestFetchFile to run on Windows. [nifi]
dan-s1 opened a new pull request, #10690:
URL: https://github.com/apache/nifi/pull/10690
<!-- Licensed to the Apache Software Foundation (ASF) under one or more -->
<!-- contributor license agreements. See the NOTICE file distributed with -->
<!-- this work for additional information regarding copyright ownership. -->
<!-- The ASF licenses this file to You under the Apache License, Version 2.0 -->
<!-- (the "License"); you may not use this file except in compliance with -->
<!-- the License. You may obtain a copy of the License at -->
<!-- http://www.apache.org/licenses/LICENSE-2.0 -->
<!-- Unless required by applicable law or agreed to in writing, software -->
<!-- distributed under the License is distributed on an "AS IS" BASIS, -->
<!-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -->
<!-- See the License for the specific language governing permissions and -->
<!-- limitations under the License. -->
# Summary
[NIFI-15387](https://issues.apache.org/jira/browse/NIFI-15387)
# Tracking
Please complete the following tracking steps prior to pull request creation.
### Issue Tracking
- [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created
### Pull Request Tracking
- [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000`
- [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000`
### Pull Request Formatting
- [ ] Pull Request based on current revision of the `main` branch
- [ ] Pull Request refers to a feature branch with one commit containing changes
# Verification
Please indicate the verification steps performed prior to pull request creation.
### Build
- [ ] Build completed using `./mvnw clean install -P contrib-check`
- [ ] JDK 21
- [ ] JDK 25
### Licensing
- [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html)
- [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files
### Documentation
- [ ] Documentation formatting appears as expected in rendered files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-15387 Re-enabled tests TestFetchFile, TestListFile and TestPutFile to run on Windows. [nifi]
Posted by "exceptionfactory (via GitHub)" <gi...@apache.org>.
exceptionfactory commented on PR #10690:
URL: https://github.com/apache/nifi/pull/10690#issuecomment-3704043878
Thanks for pointing that out @dan-s1.
@pvillard31 It appears that the commit reference closed this PR incorrectly:
https://github.com/apache/nifi/commit/a7d02cb24d32c1e593f1a47f1ad9305d979b9c46
Please review and bring in a new commit with the changes if everything looks as expected. Glad to review in more detail if needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-15387 Re-enabled tests TestFetchFile, TestListFile and TestPutFile to run on Windows. [nifi]
Posted by "exceptionfactory (via GitHub)" <gi...@apache.org>.
exceptionfactory commented on PR #10690:
URL: https://github.com/apache/nifi/pull/10690#issuecomment-3696778945
> @exceptionfactory If I disable it can I leave off a reason for now?
I would include a reason indicating an apparent filter mismatch or something along those lines, but it is fine to leave out a reason if you prefer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-15387 Re-enabled tests TestFetchFile, TestListFile and TestPutFile to run on Windows. [nifi]
Posted by "pvillard31 (via GitHub)" <gi...@apache.org>.
pvillard31 closed pull request #10690: NIFI-15387 Re-enabled tests TestFetchFile, TestListFile and TestPutFile to run on Windows.
URL: https://github.com/apache/nifi/pull/10690
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-15387 Re-enabled tests TestFetchFile, TestListFile and TestPutFile to run on Windows. [nifi]
Posted by "dan-s1 (via GitHub)" <gi...@apache.org>.
dan-s1 commented on PR #10690:
URL: https://github.com/apache/nifi/pull/10690#issuecomment-3696647180
@exceptionfactory I am not sure that is the problem as that message works on all the other boxes but for Windows. I think there is something with the filter logic on windows when the filter path is on pattern subdir2 (which is the last part of test `testFilterPathPattern`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-15387 Re-enabled tests TestFetchFile, TestListFile and TestPutFile to run on Windows. [nifi]
Posted by "dan-s1 (via GitHub)" <gi...@apache.org>.
dan-s1 commented on PR #10690:
URL: https://github.com/apache/nifi/pull/10690#issuecomment-3696770358
@exceptionfactory
If I disable it can I leave off a reason for now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-15387 Re-enabled tests TestFetchFile, TestListFile and TestPutFile to run on Windows. [nifi]
Posted by "dan-s1 (via GitHub)" <gi...@apache.org>.
dan-s1 commented on PR #10690:
URL: https://github.com/apache/nifi/pull/10690#issuecomment-3703794592
@exceptionfactory, @pvillard31 The changes in this PR were somehow written over as I do not see them on main currently. Please advise.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-15387 Re-enabled tests TestFetchFile, TestListFile and TestPutFile to run on Windows. [nifi]
Posted by "pvillard31 (via GitHub)" <gi...@apache.org>.
pvillard31 closed pull request #10690: NIFI-15387 Re-enabled tests TestFetchFile, TestListFile and TestPutFile to run on Windows.
URL: https://github.com/apache/nifi/pull/10690
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-15387 Re-enabled tests TestFetchFile, TestListFile and TestPutFile to run on Windows. [nifi]
Posted by "exceptionfactory (via GitHub)" <gi...@apache.org>.
exceptionfactory commented on PR #10690:
URL: https://github.com/apache/nifi/pull/10690#issuecomment-3696734015
> @exceptionfactory I am not sure that is the problem as that message works on all the other boxes but for Windows. I think there is something with the filter logic on windows when the filter path is on pattern subdir2 (which is the last part of test `testFilterPathPattern`). I have tried a few fixes which seem more like empty stabs. I could for now just disable this particular test for Windows although that does not seem satisfying.
Yes, it does appear to be an issue with the directory pattern matching on Windows. I'm fine with disabling only that particular test on Windows. It is probably worth creating a new Jira issue to review that particular test method more closely if you are unable to find a satisfactory solution for this particular pull request.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org