[GitHub] seojangho commented on a change in pull request #5: [NEMO-27] Element Wise Block Write

[GitBox <gi...@apache.org>]

seojangho commented on a change in pull request #5: [NEMO-27] Element Wise Block Write
URL: https://github.com/apache/incubator-nemo/pull/5#discussion_r187789144
 
 

 ##########
 File path: common/src/main/java/edu/snu/nemo/common/test/ExampleTestUtil.java
 ##########
 @@ -42,11 +42,12 @@ private ExampleTestUtil() {
    * @param resourcePath root folder for both resources.
    * @param outputFileName output file name.
    * @param testResourceFileName the test result file name.
+   * @return error message if the output is invalid.
    * @throws IOException IOException while testing.
    */
-  public static void ensureOutputValidity(final String resourcePath,
-                                          final String outputFileName,
-                                          final String testResourceFileName)
+  public static Optional<String> ensureOutputValidity(final String resourcePath,
 
 Review comment:
   It does not throw any exceptions. Then we may take a better name for this method. `getOutputMismatch`? `checkOutputMismatch`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services