You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by kiuby88 <gi...@git.apache.org> on 2016/05/02 15:50:45 UTC

[GitHub] brooklyn-library pull request: CouchDB installation fixes

Github user kiuby88 commented on a diff in the pull request:

    https://github.com/apache/brooklyn-library/pull/32#discussion_r61740415
  
    --- Diff: software/nosql/src/main/java/org/apache/brooklyn/entity/nosql/couchdb/CouchDBNodeSshDriver.java ---
    @@ -129,7 +199,7 @@ public void customize() {
         public void launch() {
             log.info("Launching  {}", entity);
             newScript(MutableMap.of(USE_PID_FILE, false), LAUNCHING)
    -                .body.append(sudo(String.format("nohup couchdb -p %s -a %s -o couchdb-console.log -e couchdb-error.log -b &", getPidFile(), Os.mergePathsUnix(getRunDir(), getCouchDBConfigFileName()))))
    +                .body.append(String.format("nohup ./bin/couchdb -p %s -a %s -o couchdb-console.log -e couchdb-error.log -b &", getPidFile(), Os.mergePathsUnix(getRunDir(), getCouchDBConfigFileName())))
    --- End diff --
    
    The bin folder string is used in some different parts. Would it make sense to wrap `/bin/couchdb` folder with a method? 
    Moreover, I looks that couchdb files are installed over different folders:
    `/usr/bin/couchdb` contains the launch ssh file, and `/etc/couchdb` contains some configuration files  and `/usr/share/couchdb` contains the source to execute the server. Then, would it make sense try to store these paths in any variable or sensor? It looks that these values are concrete values of this driver, but  may it be useful for future improvement?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---