You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/12/20 14:52:24 UTC
[GitHub] [incubator-nuttx] juniskane opened a new pull request #5041: Fix typos in comments and Kconfig files
juniskane opened a new pull request #5041:
URL: https://github.com/apache/incubator-nuttx/pull/5041
## Summary
Just some spelling errors and other minor corrections to comments here and there, accumulated over time.
## Impact
No functional change.
## Testing
N7A
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #5041: Fix typos in comments and Kconfig files
Posted by GitBox <gi...@apache.org>.
gustavonihei commented on a change in pull request #5041:
URL: https://github.com/apache/incubator-nuttx/pull/5041#discussion_r772678131
##########
File path: arch/Kconfig
##########
@@ -423,7 +423,7 @@ config ARCH_USE_TEXT_HEAP
default n
depends on ARCH_HAVE_TEXT_HEAP
---help---
- This option enables architecture-sepecific memory allocator
+ This option enables architecture-specific memory allocator
for dynamic code loading. For example, ESP32 has a separate memory
Review comment:
```suggestion
for dynamic code loading. For example, ESP32 has separate memory
```
Just one more to add to the package :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] juniskane commented on a change in pull request #5041: Fix typos in comments and Kconfig files
Posted by GitBox <gi...@apache.org>.
juniskane commented on a change in pull request #5041:
URL: https://github.com/apache/incubator-nuttx/pull/5041#discussion_r772881018
##########
File path: sched/Kconfig
##########
@@ -13,14 +13,6 @@ menuconfig DISABLE_OS_API
disable functions unless you want to restrict usage
of those APIs.
- There are certain dependency relationships in these
- features.
-
- 1) mq_notify logic depends on signals to awaken tasks
- waiting for queues to become full or empty.
- 2) pthread_condtimedwait() depends on signals to wake
- up waiting tasks.
-
Review comment:
That section was meaningful only when we had CONFIG_DISABLE_SIGNALS. Makes little sense to list dependencies to features that cannot in fact be removed. Wording "in these features" refers to the set of features than can be disabled by subitems of CONFIG_DISABLE_OS_API so it is misleading to imply that signals are part of it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] hartmannathan commented on a change in pull request #5041: Fix typos in comments and Kconfig files
Posted by GitBox <gi...@apache.org>.
hartmannathan commented on a change in pull request #5041:
URL: https://github.com/apache/incubator-nuttx/pull/5041#discussion_r773232216
##########
File path: sched/Kconfig
##########
@@ -13,14 +13,6 @@ menuconfig DISABLE_OS_API
disable functions unless you want to restrict usage
of those APIs.
- There are certain dependency relationships in these
- features.
-
- 1) mq_notify logic depends on signals to awaken tasks
- waiting for queues to become full or empty.
- 2) pthread_condtimedwait() depends on signals to wake
- up waiting tasks.
-
Review comment:
Perfect! Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #5041: Fix typos in comments and Kconfig files
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #5041:
URL: https://github.com/apache/incubator-nuttx/pull/5041
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #5041: Fix typos in comments and Kconfig files
Posted by GitBox <gi...@apache.org>.
gustavonihei commented on a change in pull request #5041:
URL: https://github.com/apache/incubator-nuttx/pull/5041#discussion_r772678131
##########
File path: arch/Kconfig
##########
@@ -423,7 +423,7 @@ config ARCH_USE_TEXT_HEAP
default n
depends on ARCH_HAVE_TEXT_HEAP
---help---
- This option enables architecture-sepecific memory allocator
+ This option enables architecture-specific memory allocator
for dynamic code loading. For example, ESP32 has a separate memory
Review comment:
```suggestion
for dynamic code loading. For example, ESP32 has separate memory
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] hartmannathan commented on a change in pull request #5041: Fix typos in comments and Kconfig files
Posted by GitBox <gi...@apache.org>.
hartmannathan commented on a change in pull request #5041:
URL: https://github.com/apache/incubator-nuttx/pull/5041#discussion_r772465057
##########
File path: sched/Kconfig
##########
@@ -13,14 +13,6 @@ menuconfig DISABLE_OS_API
disable functions unless you want to restrict usage
of those APIs.
- There are certain dependency relationships in these
- features.
-
- 1) mq_notify logic depends on signals to awaken tasks
- waiting for queues to become full or empty.
- 2) pthread_condtimedwait() depends on signals to wake
- up waiting tasks.
-
Review comment:
Everything else looks good, but why remove this section? Is it stale?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #5041: Fix typos in comments and Kconfig files
Posted by GitBox <gi...@apache.org>.
gustavonihei commented on a change in pull request #5041:
URL: https://github.com/apache/incubator-nuttx/pull/5041#discussion_r772678131
##########
File path: arch/Kconfig
##########
@@ -423,7 +423,7 @@ config ARCH_USE_TEXT_HEAP
default n
depends on ARCH_HAVE_TEXT_HEAP
---help---
- This option enables architecture-sepecific memory allocator
+ This option enables architecture-specific memory allocator
for dynamic code loading. For example, ESP32 has a separate memory
Review comment:
```suggestion
for dynamic code loading. For example, ESP32 has separate memory
```
Just one more to add to the package hehe
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #5041: Fix typos in comments and Kconfig files
Posted by GitBox <gi...@apache.org>.
gustavonihei commented on a change in pull request #5041:
URL: https://github.com/apache/incubator-nuttx/pull/5041#discussion_r772678131
##########
File path: arch/Kconfig
##########
@@ -423,7 +423,7 @@ config ARCH_USE_TEXT_HEAP
default n
depends on ARCH_HAVE_TEXT_HEAP
---help---
- This option enables architecture-sepecific memory allocator
+ This option enables architecture-specific memory allocator
for dynamic code loading. For example, ESP32 has a separate memory
Review comment:
```suggestion
for dynamic code loading. For example, ESP32 has separate memory
```
Just one more to add to the package :smiley:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org