[jira] [Commented] (SENTRY-410) Some negative test cases do not check for specific Sentry exceptions

["Liam Sargent (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SENTRY-410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16343476#comment-16343476 ] 

Liam Sargent commented on SENTRY-410:
-------------------------------------

When I check the error message, I can do a String.contains on keywords to see if there is a match on keywords. Will contribute patch for this during the week

> Some negative test cases do not check for specific Sentry exceptions
> --------------------------------------------------------------------
>
>                 Key: SENTRY-410
>                 URL: https://issues.apache.org/jira/browse/SENTRY-410
>             Project: Sentry
>          Issue Type: Test
>    Affects Versions: 1.4.0
>            Reporter: Sravya Tirukkovalur
>            Assignee: Liam Sargent
>            Priority: Major
>             Fix For: 2.1.0
>
>
> in Context.java:
> {noformat}
> // verify that the sqlexception is due to authorization failure
>   public void verifyAuthzException(SQLException sqlException) throws SQLException{
>     verifyAuthzExceptionForState(sqlException, AUTHZ_EXCEPTION_SQL_STATE);
>   }
> {noformat}
> This just checks for status 42000, which would also be the case for other failures other than SemanticExceptions. We need to make stronger checks in the tests.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)