[GitHub] [airflow] feluelle commented on a change in pull request #14642: Entrypoint support in docker operator

[GitBox <gi...@apache.org>]

feluelle commented on a change in pull request #14642:
URL: https://github.com/apache/airflow/pull/14642#discussion_r607565677



##########
File path: airflow/providers/docker/operators/docker.py
##########
@@ -318,18 +321,20 @@ def _get_cli(self) -> APIClient:
             tls_config = self.__get_tls_config()
             return APIClient(base_url=self.docker_url, version=self.api_version, tls=tls_config)
 
-    def get_command(self) -> Union[List[str], str]:
+    @staticmethod
+    def get_command(command: Union[str, List[str]]) -> Union[List[str], str]:
         """
         Retrieve command(s). if command string starts with [, it returns the command list)

Review comment:
       Just wondering.. Why do we actually support this? Is it really necessary for users to pass a string containing a list instead of just a list?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org