Review Request 13044: solator: Refactor slave forked pid checkpointing.

[Eric Biederman <eb...@xmission.com>]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13044/
-----------------------------------------------------------

Review request for mesos, Benjamin Hindman, Ben Mahler, Ian Downes, and Vinod Kone.


Repository: mesos-git


Description
-------

isolator: Refactor slave forked pid checkpointing.

Extract the code out of launcher.setup and into it's own function
checkpointForkedPid.

Call checkpointForkedPid directly from the process and the cgroup isolator.

This makes the code a little cleaner as launching has little to do with
checkpointing and it makes it makes it prepares the way for utilizing
the pid namespace in mesos-slave.


Diffs
-----

  src/launcher/launcher.cpp c7d2c30 
  src/slave/cgroups_isolator.cpp 0faf7d5 
  src/slave/process_isolator.cpp cd794f6 
  src/slave/state.hpp 08e3617 
  src/slave/state.cpp e910ab7 

Diff: https://reviews.apache.org/r/13044/diff/


Testing
-------

make -j8 check

Watched the tests pass.  This is just code motion so I am not concerned about introducing bugs.

I will note that I did play with passing in the wrong pid and the tests still passed, so there seems to be a bit of a gap in the test coverage.


Thanks,

Eric Biederman