You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by viirya <gi...@git.apache.org> on 2016/09/17 09:41:06 UTC
[GitHub] spark pull request #15128: [SPARK-17574][Core] Cache ShuffleExchange RDD whe...
GitHub user viirya opened a pull request:
https://github.com/apache/spark/pull/15128
[SPARK-17574][Core] Cache ShuffleExchange RDD when the exchange is reused
## What changes were proposed in this pull request?
We have the rule `ReuseExchange` to reuse exchange in the physical plan. However, for a `ShuffleExchange` we still need to retrieve remote blocks again when the shuffle exchange is reused. We can cache the RDD of the reused `ShuffleExchange` to avoid transferring remote blocks again.
## How was this patch tested?
Manual tests. This patch can avoid transferring remote blocks again when a shuffle exchange is reused.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/viirya/spark-1 cache-reused-shuffle
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/15128.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #15128
----
commit cbbaf318ecb9e21df464f487dd4dbb37ceee3923
Author: Liang-Chi Hsieh <si...@tw.ibm.com>
Date: 2016-09-17T09:34:20Z
Cache ShuffleExchange RDD when the exchange is reused.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #15128: [SPARK-17574][Core] Cache ShuffleExchange RDD when the e...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15128
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #15128: [SPARK-17574][Core] Cache ShuffleExchange RDD when the e...
Posted by viirya <gi...@git.apache.org>.
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/15128
Need more thinking about this. Close this now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #15128: [SPARK-17574][Core] Cache ShuffleExchange RDD when the e...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15128
**[Test build #65531 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65531/consoleFull)** for PR 15128 at commit [`cbbaf31`](https://github.com/apache/spark/commit/cbbaf318ecb9e21df464f487dd4dbb37ceee3923).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #15128: [SPARK-17574][Core] Cache ShuffleExchange RDD when the e...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15128
**[Test build #65531 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65531/consoleFull)** for PR 15128 at commit [`cbbaf31`](https://github.com/apache/spark/commit/cbbaf318ecb9e21df464f487dd4dbb37ceee3923).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #15128: [SPARK-17574][Core] Cache ShuffleExchange RDD whe...
Posted by viirya <gi...@git.apache.org>.
Github user viirya closed the pull request at:
https://github.com/apache/spark/pull/15128
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #15128: [SPARK-17574][Core] Cache ShuffleExchange RDD when the e...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15128
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65531/
Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org