You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Neil Conway <ne...@gmail.com> on 2016/01/26 01:46:06 UTC

Review Request 42764: stout: Improved code style slightly.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42764/
-----------------------------------------------------------

Review request for mesos and Jie Yu.


Repository: mesos


Description
-------

stout: Improved code style slightly.


Diffs
-----

  3rdparty/libprocess/3rdparty/stout/include/stout/strings.hpp f302d2a89f3f2a96bd8eea04eff7f7a50a5b31fd 
  3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp dc8cf74f1bc90f6234a00d8cbca9c93a350cffa0 

Diff: https://reviews.apache.org/r/42764/diff/


Testing
-------

make check


Thanks,

Neil Conway


Re: Review Request 42764: stout: Improved code style slightly.

Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42764/#review116238
-----------------------------------------------------------


Ship it!




Ship It!

- Jie Yu


On Jan. 26, 2016, 12:46 a.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42764/
> -----------------------------------------------------------
> 
> (Updated Jan. 26, 2016, 12:46 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> stout: Improved code style slightly.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/strings.hpp f302d2a89f3f2a96bd8eea04eff7f7a50a5b31fd 
>   3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp dc8cf74f1bc90f6234a00d8cbca9c93a350cffa0 
> 
> Diff: https://reviews.apache.org/r/42764/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Neil Conway
> 
>


Re: Review Request 42764: stout: Improved code style slightly.

Posted by Anand Mazumdar <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42764/#review116235
-----------------------------------------------------------


Ship it!




Ship It!

- Anand Mazumdar


On Jan. 26, 2016, 12:46 a.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42764/
> -----------------------------------------------------------
> 
> (Updated Jan. 26, 2016, 12:46 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> stout: Improved code style slightly.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/strings.hpp f302d2a89f3f2a96bd8eea04eff7f7a50a5b31fd 
>   3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp dc8cf74f1bc90f6234a00d8cbca9c93a350cffa0 
> 
> Diff: https://reviews.apache.org/r/42764/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Neil Conway
> 
>